fix(telemetry): gate preamble session tracking#1188
Open
jbetala7 wants to merge 2 commits into
Open
Conversation
47af9f1 to
017a2f7
Compare
Session-file tracking (mkdir/touch/find ~/.gstack/sessions), the analytics pending-marker loop, and timeline-log all ran unconditionally in the preamble and completion-status resolvers, even with telemetry: off. That contradicts the documented behavior (telemetry off = no local analytics) and tripped enterprise security scanners on the OPENCLAW_SESSION string and bare find commands in shell init. - Gate session tracking, analytics writes, the pending-finalize loop, and timeline-log behind $_TEL != off in both resolvers. - Extract the OPENCLAW_SESSION check into bin/gstack-spawned-session-status so the orchestrator env-var name no longer appears in every generated SKILL.md. - Leave plan-mode detection untouched (separate concern). - README: telemetry off now disables local analytics + session artifacts too. - Tests cover the gating, the helper, and the absent OPENCLAW_SESSION string. Fixes garrytan#1150 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Regenerated via bun run gen:skill-docs --host all after the preamble/ completion-status resolver change. No hand edits. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
76f4c2b to
bacd6a4
Compare
Contributor
Author
|
Rebased cleanly onto current
Verification:
Heads-up on overlap: #1747 proposes echoing the |
garrytan
added a commit
that referenced
this pull request
Jun 3, 2026
… 401ing
The report job upserts its E2E summary via the REST /issues/{n}/comments
endpoints (gh api), which GITHUB_TOKEN gates behind the issues permission, not
pull-requests. The job only granted pull-requests:write, so the GET 401'd on
every PR that produced eval artifacts (PRs with no artifacts exit early and never
reach the call, which masked it). Pre-existing; surfaced here because this PR
runs evals. Confirmed identical failure on #1188 and #1621.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1150
Summary
telemetry != offOPENCLAW_SESSIONstring directlyRoot cause
The preamble generator still emitted several local tracking side effects unconditionally even though
telemetry: offis documented as disabling local analytics, and it embedded theOPENCLAW_SESSIONenv var name directly into every generated SKILL.md preamble.Testing