Support for Kubernetes 1.34 by tobschli · Pull Request #12883 · gardener/gardener

tobschli · 2025-09-03T14:25:01Z

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

We performed the changes by following the new Kubernetes version guide and comparing how changes have been done for previous Kubernetes versions, e.g., #10472.

⚠️ This PR only contains the Gardener part for supporting 1.34 - there will/must be follow-up PRs for each extension repository where individual support gets added.

Code changes have been tested in the following scenarios using the local provider:

Create/Delete a new (normal/workerless) Shoot cluster with 1.34.0
Upgrade an existing (normal/workerless) Shoot cluster to 1.34.0

Release note:

Gardener can now support clusters with Kubernetes version 1.34. To allow creation/update of 1.34 clusters you will have to update the version of your provider extension(s) to a version that supports 1.34 as well. Please consult the respective releases and notes in the provider extension's repository.

Gardener can now support clusters with Kubernetes version 1.34. Extension developers have to prepare individual extensions as well to work with 1.34.

gardener-prow · 2025-09-03T14:25:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tobschli · 2025-09-03T14:25:17Z

/invite @ScheererJ

tobschli · 2025-09-22T07:46:07Z

/hold

Still WIP, but marked as ready for review in order to let the tests run

vpnachev · 2025-09-23T12:58:34Z

Shouldn't this PR update the k8s.io/* dependencies from v0.33.* to v0.34.*?

tobschli · 2025-09-23T13:30:57Z

Shouldn't this PR update the k8s.io/* dependencies from v0.33.* to v0.34.*?

We just have not until now, this is still WIP

tobschli · 2025-09-24T11:38:00Z

new Kubernetes version guide

Seems like in the past this was done as part of a separate PR (ref).
We could also do it here, I guess. Though it makes the PR even harder to review.

ScheererJ · 2025-10-30T15:06:52Z

/lgtm

gardener-prow · 2025-10-30T15:07:02Z

LGTM label has been added.

Details

Git tree hash: c3478940c44357b5c2b12fa04634b8e475a79937

Without it, the `kube-apiserver` does not start, because the `EndpointSlice` informers do not sync.

tobschli · 2025-10-30T15:24:51Z

/unhold

rfranzke

/lgtm

gardener-prow · 2025-10-31T09:30:17Z

LGTM label has been added.

Details

Git tree hash: dc6f84506a5c9fdd4a519bae536a9128216cec98

LucaBernstein

/lgtm

marc1404

Thank you for working towards bringing support for Kubernetes v1.34 to Gardener. 👏
The commit structure and commit messages are very helpful during review. 🙇‍♂️

I left a few comments, but they don't necessarily need to be integrated into this PR. Therefor:
/lgtm

Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>

marc1404

/lgtm

Thanks for addressing my suggestions 🙏

gardener-prow · 2025-11-03T10:43:03Z

LGTM label has been added.

Details

Git tree hash: d84ee3b5fb998bff53377b0440badbe34e5cb534

gardener-prow · 2025-11-03T10:48:28Z

@tobschli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gardener-e2e-kind-operator-seed	`4a3e8e0`	link	true	`/test pull-gardener-e2e-kind-operator-seed`

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

marc1404

/approve

gardener-prow · 2025-11-03T15:23:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [marc1404]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* feat: Allow instantiating v1.34 Kubernetes clients * docs: Update supported Kubernetes versions in docs * docs: align docs with usage * feat: Maintain feature gates for v1.34 ./hack/compare-k8s-feature-gates.sh 1.33 1.34 Feature gates added in 1.34 compared to 1.33: ClearingNominatedNodeNameAfterBinding ContainerRestartRules DRAConsumableCapacity DRADeviceBindingConditions DRAExtendedResource DRASchedulerFilterTimeout DetectCacheInconsistency EnvFiles HostnameOverride InPlacePodVerticalScalingExclusiveMemory KubeletPodResourcesListUseActivePods MatchLabelKeysInPodTopologySpreadSelectorMerge NominatedNodeNameForExpectation PodCertificateRequest PreventStaticPodAPIReferences ProbeHostPodSecurityStandards RelaxedServiceNameValidation SchedulerAsyncAPICalls SizeBasedListCostEstimate StructuredAuthenticationConfigurationEgressSelector TokenRequestServiceAccountUIDValidation Feature gates removed in 1.34 compared to 1.33: DevicePluginCDIDevices ElasticIndexedJob LegacySidecarContainers PodDisruptionConditions StatefulSetStartOrdinal Feature gates locked to default true in 1.34 compared to 1.33: AnonymousAuthConfigurableEndpoints APIServerTracing AuthorizeNodeWithSelectors AuthorizeWithSelectors ConsistentListFromCache JobPodReplacementPolicy KubeletCgroupDriverFromCRI KubeletTracing MultiCIDRServiceAllocator NodeSwap OrderedNamespaceDeletion PodLifecycleSleepAction PodLifecycleSleepActionAllowZero ProbeHostPodSecurityStandards RecoverVolumeExpansionFailure RelaxedDNSSearchValidation RelaxedEnvironmentVariableValidation ResilientWatchCacheInitialization SchedulerQueueingHints SeparateTaintEvictionController StreamingCollectionEncodingToJSON StreamingCollectionEncodingToProtobuf StructuredAuthenticationConfiguration WinDSR WinOverlay Feature gates locked to default false in 1.34 compared to 1.33: * feat: Maintain kube-apiserver admission plugins for 1.34 ./hack/compare-k8s-admission-plugins.sh 1.33 1.34 Admission plugins added in 1.34 compared to 1.33: Admission plugins removed in 1.34 compared to 1.33: * feat: Maintain apigroups for 1.34 ./hack/compare-k8s-api-groups.sh 1.33 1.34 Kubernetes API group versions added in 1.34 compared to 1.33: resource.k8s.io/v1 Kubernetes API GVRs added in 1.34 compared to 1.33: admissionregistration.k8s.io/v1beta1/mutatingadmissionpolicies admissionregistration.k8s.io/v1beta1/mutatingadmissionpolicybindings certificates.k8s.io/v1alpha1/podcertificaterequests resource.k8s.io/v1/deviceclasses resource.k8s.io/v1/resourceclaims resource.k8s.io/v1/resourceclaimtemplates resource.k8s.io/v1/resourceslices storage.k8s.io/v1/volumeattributesclasses Kubernetes API group versions removed in 1.34 compared to 1.33: networking.k8s.io/v1alpha1 Kubernetes API GVRs removed in 1.34 compared to 1.33: networking.k8s.io/v1alpha1/ipaddresses networking.k8s.io/v1alpha1/servicecidrs resource.k8s.io/v1alpha3/deviceclasses resource.k8s.io/v1alpha3/resourceclaims resource.k8s.io/v1alpha3/resourceclaimtemplates resource.k8s.io/v1alpha3/resourceslices * feat: Maintain kubernetes-controller-manager controller mappings kube-controller-manager controllers added in 1.34 compared to 1.33: Added Controllers for API Group [certificates/v1alpha1]: podcertificaterequest-cleaner-controller Added Controllers for API Group [resource/v1]: device-taint-eviction-controller resourceclaim-controller Added Controllers for API Group [storage/v1]: volumeattributesclass-protection-controller kube-controller-manager controllers removed in 1.34 compared to 1.33: Removed Controllers for API Group [resource/v1beta1]: device-taint-eviction-controller resourceclaim-controller Removed Controllers for API Group [storage/v1beta1]: volumeattributesclass-protection-controller * feat: Maintain unneeded controllers for workerless Shoots for Kubernetes 1.34 * chore: Update DaemonSet controller comments * chore: Add Kubernetes v1.34.0 to provider-local cloud profile * chore: Bump kindest/node version to 1.34.0 * chore: Change example Shoot to refer CredentialsBinding * Set `trafficDistribution` to `PreferSameZone` for kubernetes versions `>= 1.34` * Adapt charts to new `trafficDistribution` value * Adapt tests to new `trafficDistribution` value * Update TopologyAwareRouting documentation * Address linting findings * Use `PreferClose` for ETCD's clientService trafficDistribution * --- SEPARATOR --- * Align `node-problem-detector` images Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com> * Adapt to new labels for metrics kubernetes/kubernetes#130161 * Enable `discovery.k8s.io/v1` API for workerless `Shoot`s Without it, the `kube-apiserver` does not start, because the `EndpointSlice` informers do not sync. * Fix wording / typo Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com> --------- Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com> Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>

gardener-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension labels Sep 3, 2025

gardener-prow Bot requested review from ialidzhikov and marc1404 September 3, 2025 14:25

gardener-prow Bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Sep 3, 2025

gardener-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 3, 2025

tobschli mentioned this pull request Sep 9, 2025

☂️-Issue for "Support for Kubernetes v1.34” #12814

Closed

26 tasks

gardener-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2025

tobschli force-pushed the kubernetes-134 branch from 4ef169e to 4ee5f02 Compare September 22, 2025 07:43

gardener-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2025

tobschli marked this pull request as ready for review September 22, 2025 07:45

gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025

gardener-prow Bot requested a review from vitanovs September 22, 2025 07:45

tobschli marked this pull request as draft September 22, 2025 07:45

gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025

tobschli marked this pull request as ready for review September 22, 2025 07:45

gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025

gardener-prow Bot requested review from shafeeqes and timebertt September 22, 2025 07:45

gardener-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2025

tobschli force-pushed the kubernetes-134 branch from 070c9f0 to 4a3e8e0 Compare September 22, 2025 14:57

tobschli changed the title ~~Support for Kubernetes 1.34~~ [WIP] Support for Kubernetes 1.34 Sep 23, 2025

gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025

gardener-prow Bot requested a review from ScheererJ October 30, 2025 15:01

ScheererJ changed the title ~~[WIP] Support for Kubernetes 1.34~~ Support for Kubernetes 1.34 Oct 30, 2025

gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025

gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025

Enable discovery.k8s.io/v1 API for workerless Shoots

0131a43

Without it, the `kube-apiserver` does not start, because the `EndpointSlice` informers do not sync.

tobschli force-pushed the kubernetes-134 branch from d9b0091 to 0131a43 Compare October 30, 2025 15:21

gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025

gardener-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025

rfranzke reviewed Oct 31, 2025

View reviewed changes

gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025

LucaBernstein reviewed Oct 31, 2025

View reviewed changes

marc1404 reviewed Oct 31, 2025

View reviewed changes

Fix wording / typo

6532482

Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>

gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

marc1404 reviewed Nov 3, 2025

View reviewed changes

gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

marc1404 reviewed Nov 3, 2025

View reviewed changes

gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025

gardener-prow Bot merged commit 803429a into gardener:master Nov 3, 2025
18 checks passed

ialidzhikov mentioned this pull request Nov 20, 2025

docs: Update the supported Kubernetes versions for Shoots #13503

Merged

This was referenced Feb 3, 2026

Adapt to the trafficDistribution: PreferClose -> trafficDistribution: PreferSameZone change for topology-aware Services in K8s 1.34 #13942

Closed

controlplane chart: Fix gardener-apiserver values for topology-aware routing #13943

Merged

Conversation

tobschli commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gardener-prow Bot commented Sep 3, 2025

Uh oh!

tobschli commented Sep 3, 2025

Uh oh!

tobschli commented Sep 22, 2025

Uh oh!

vpnachev commented Sep 23, 2025

Uh oh!

tobschli commented Sep 23, 2025

Uh oh!

tobschli commented Sep 24, 2025

Uh oh!

ScheererJ commented Oct 30, 2025

Uh oh!

gardener-prow Bot commented Oct 30, 2025

Uh oh!

tobschli commented Oct 30, 2025

Uh oh!

rfranzke left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow Bot commented Oct 31, 2025

Uh oh!

LucaBernstein left a comment

Choose a reason for hiding this comment

Uh oh!

marc1404 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc1404 left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow Bot commented Nov 3, 2025

Uh oh!

gardener-prow Bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc1404 left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow Bot commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tobschli commented Sep 3, 2025 •

edited

Loading

marc1404 left a comment •

edited

Loading

gardener-prow Bot commented Nov 3, 2025 •

edited

Loading