Skip to content

Commit fb7fb7b

Browse files
jcpunkaanm
authored andcommitted
fix: incorrect schema entries for cpu limits
CPU limits can either be strings or integers. Fixes: cilium#43732 Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
1 parent bf98364 commit fb7fb7b

3 files changed

Lines changed: 30 additions & 3 deletions

File tree

install/kubernetes/cilium/values.schema.json

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,7 +1674,10 @@
16741674
"limits": {
16751675
"properties": {
16761676
"cpu": {
1677-
"type": "integer"
1677+
"type": [
1678+
"integer",
1679+
"string"
1680+
]
16781681
},
16791682
"memory": {
16801683
"type": "string"
@@ -1685,7 +1688,10 @@
16851688
"requests": {
16861689
"properties": {
16871690
"cpu": {
1688-
"type": "string"
1691+
"type": [
1692+
"integer",
1693+
"string"
1694+
]
16891695
},
16901696
"memory": {
16911697
"type": "string"
@@ -4665,7 +4671,10 @@
46654671
"requests": {
46664672
"properties": {
46674673
"cpu": {
4668-
"type": "string"
4674+
"type": [
4675+
"integer",
4676+
"string"
4677+
]
46694678
},
46704679
"memory": {
46714680
"type": "string"

install/kubernetes/cilium/values.yaml

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

install/kubernetes/cilium/values.yaml.tmpl

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,9 +811,15 @@ cni:
811811
# -- Specifies the resources for the cni initContainer
812812
resources:
813813
requests:
814+
# @schema
815+
# type: [integer, string]
816+
# @schema
814817
cpu: 100m
815818
memory: 10Mi
816819
limits:
820+
# @schema
821+
# type: [integer, string]
822+
# @schema
817823
cpu: 1
818824
memory: 1Gi
819825
# -- Enable route MTU for pod netns when CNI chaining is used
@@ -3305,6 +3311,9 @@ nodeinit:
33053311
# ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
33063312
resources:
33073313
requests:
3314+
# @schema
3315+
# type: [integer, string]
3316+
# @schema
33083317
cpu: 100m
33093318
memory: 100Mi
33103319
# -- Security context to be added to nodeinit pods.

0 commit comments

Comments
 (0)