-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Helm: schema expects cni.resources.limits.cpu to be an integer #43732
Copy link
Copy link
Closed
Labels
area/agentCilium agent related.Cilium agent related.area/helmImpacts helm charts and user deployment experienceImpacts helm charts and user deployment experiencekind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/community-reportThis was reported by a user in the Cilium community, eg via Slack.This was reported by a user in the Cilium community, eg via Slack.release-blocker/1.19This issue will prevent the release of the next version of Cilium.This issue will prevent the release of the next version of Cilium.
Description
Is there an existing issue for this?
- I have searched the existing issues
Version
equal or higher than v1.18.5 and lower than v1.19.0
What happened?
This commit introduced a schema change for cni.resources.limits.cpu which only accepts integers now:
464bdca
This is inconsistent compared to other values including the requests for CPU:
| parameter | expected type |
|---|---|
| cni.resources.limits.cpu | integer |
| cni.resources.limits.memory | string |
| cni.resources.requests.memory | string |
| cni.resources.limits.memory | string |
How can we reproduce the issue?
Typical setup:
cni:
resources:
requests:
cpu: 100m
memory: 10Mi
limits:
cpu: 200m
memory: 1Gi
Note how cni.resources.requests.memory is also a string and that is fine. Only cni.resources.limits.cpu has issues. These should both have the same format and should be strings.
Cilium Version
Kernel Version
NaN
Kubernetes Version
1.33
Regression
Sysdump
No response
Relevant log output
Anything else?
No response
Cilium Users Document
- Are you a user of Cilium? Please add yourself to the Users doc
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/agentCilium agent related.Cilium agent related.area/helmImpacts helm charts and user deployment experienceImpacts helm charts and user deployment experiencekind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/community-reportThis was reported by a user in the Cilium community, eg via Slack.This was reported by a user in the Cilium community, eg via Slack.release-blocker/1.19This issue will prevent the release of the next version of Cilium.This issue will prevent the release of the next version of Cilium.
Type
Projects
Status
Done