Skip to content

fix: incorrect schema entries for cpu limits#43735

Merged
aanm merged 1 commit intocilium:mainfrom
jcpunk:cpulimit-schema
Jan 14, 2026
Merged

fix: incorrect schema entries for cpu limits#43735
aanm merged 1 commit intocilium:mainfrom
jcpunk:cpulimit-schema

Conversation

@jcpunk
Copy link
Copy Markdown
Contributor

@jcpunk jcpunk commented Jan 13, 2026

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

CPU limits can either be strings or integers.
Fixes: #43732

<!-- Enter the release note text here if needed or remove this section! -->

CPU limits can either be strings or integers.
Fixes: cilium#43732

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@jcpunk jcpunk requested a review from a team as a code owner January 13, 2026 17:56
@jcpunk jcpunk requested a review from nebril January 13, 2026 17:56
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 13, 2026
@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. release-blocker/1.19 This issue will prevent the release of the next version of Cilium. labels Jan 13, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2026
@joestringer joestringer moved this from Proposed to Active in Release blockers Jan 13, 2026
@joestringer joestringer added the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Jan 13, 2026
@joestringer
Copy link
Copy Markdown
Member

/test

@joestringer
Copy link
Copy Markdown
Member

Thanks, LGTM at a glance but I'm not a code owner for this area. Will defer to @helm @nebril for official review.

@joestringer joestringer enabled auto-merge January 13, 2026 18:03
@aanm aanm disabled auto-merge January 14, 2026 08:22
@aanm aanm merged commit fb7fb7b into cilium:main Jan 14, 2026
82 checks passed
@github-project-automation github-project-automation bot moved this from Active to Done in Release blockers Jan 14, 2026
@jcpunk jcpunk deleted the cpulimit-schema branch January 14, 2026 15:34
@gandro gandro mentioned this pull request Jan 15, 2026
3 tasks
@gandro gandro added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Jan 15, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Jan 15, 2026
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-blocker/1.19 This issue will prevent the release of the next version of Cilium. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

Archived in project
Status: Released

Development

Successfully merging this pull request may close these issues.

Helm: schema expects cni.resources.limits.cpu to be an integer

4 participants