Skip to content

Update bam-to-sam and sam-to-bam to remove need for wrapper script.#75

Closed
davebx wants to merge 5 commits intogalaxyproject:masterfrom
davebx:bam_sam_converters
Closed

Update bam-to-sam and sam-to-bam to remove need for wrapper script.#75
davebx wants to merge 5 commits intogalaxyproject:masterfrom
davebx:bam_sam_converters

Conversation

@davebx
Copy link
Contributor

@davebx davebx commented Mar 12, 2015

No description provided.

@bgruening
Copy link
Member

@davebx just wondering if an <stdio> tag would be useful?
Otherwise this looks good to me and it is a huge improvement!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the version number is decreasing, not good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the tool got renamed and re-id'd; this looks like some mismatch

@davebx
Copy link
Contributor Author

davebx commented Mar 13, 2015

@bgruening agreed. Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this works anyway, but I suggest to s/$input1/$source.input1/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@martenson
Copy link
Member

closed in favor of #84

@martenson martenson closed this Mar 18, 2015
jmchilton added a commit to jmchilton/planemo that referenced this pull request Apr 14, 2015
Reflect the fact that I don't think the output should actually be meant to be a human readable tool (nothing but problems - see galaxyproject#125, galaxyproject#110, galaxyproject/tools-devteam#75).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants