Fix quay repository presence check for single target builds#993
Merged
nsoranzo merged 2 commits intogalaxyproject:masterfrom Feb 5, 2020
Conversation
Since the v2_image_name for a single target doesn't include the build suffix given by bioconda (e.`--hc9558a2_0`) we don't get an exact match from the quay.io api.
mvdbeek
added a commit
to mvdbeek/planemo-monitor
that referenced
this pull request
Jan 30, 2020
Member
Author
|
this isn't actually meant for merging, I think the logic actually belongs in galaxy-tool-util but I wanted to have a check to see if / what else is missing for planemo monitor. |
9885715 to
f396d5b
Compare
f396d5b to
7e7a915
Compare
mvdbeek
added a commit
to mvdbeek/planemo-monitor
that referenced
this pull request
Jan 30, 2020
mvdbeek
added a commit
to mvdbeek/planemo-monitor
that referenced
this pull request
Jan 30, 2020
Member
Author
|
OK, we already had everything in place to do this right in galaxy-tool-util. |
bgruening
added a commit
to galaxyproject/planemo-monitor
that referenced
this pull request
Jan 30, 2020
Try with my branch, galaxyproject/planemo#993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the v2_image_name for a single target doesn't include the build
suffix given by bioconda (e.
--hc9558a2_0) we don't get an exactmatch from the quay.io api.