Skip to content

Replace deprecated galaxy-lib requirement with galaxy-tool-util#978

Merged
jmchilton merged 6 commits intogalaxyproject:masterfrom
nsoranzo:galaxy-tool-util
Jan 15, 2020
Merged

Replace deprecated galaxy-lib requirement with galaxy-tool-util#978
jmchilton merged 6 commits intogalaxyproject:masterfrom
nsoranzo:galaxy-tool-util

Conversation

@nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Dec 19, 2019

Depends on common-workflow-language/cwltool#1228 and galaxyproject/galaxy#9146 (with corresponding new PyPI releases).

nsoranzo and others added 4 commits December 19, 2019 13:18
They are presently missing from sdist distributions, which means
that:

```
pip install --no-binary :all: planemo
```

does not install Planemo dependencies.
@mr-c
Copy link
Contributor

mr-c commented Dec 29, 2019

@nsoranzo
Copy link
Member Author

The call to cwltool's load_tool.validate_document() method in https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tool_util/cwl/schema.py#L42 was broken in commit common-workflow-language/cwltool@526f36f
Any help on a fix for that in galaxy-tool-util would be appreciated!

@jmchilton
Copy link
Member

jmchilton commented Jan 1, 2020

It is almost certainly fixed in the CWL branch of Galaxy already. I'll see what I can do.

@mvdbeek
Copy link
Member

mvdbeek commented Jan 15, 2020

Hmm, somethings hanging in the full test suite, possibly test_local_conda_dependencies_version. I have no idea what is going on there.

@jmchilton
Copy link
Member

This process 30877 s008 S+ 0:00.00 /bin/bash -e /Users/john/miniconda3/conda-bld/fleeqtk_1579101053099/test_tmp/run_test.sh seems to hang locally. I don't know if this always hung on Macs though.

@jmchilton
Copy link
Member

Replacing the fleeqtk test with 'true' ... https://github.com/jmchilton/planemo/runs/391338751 ... lets see what happens.

@mvdbeek
Copy link
Member

mvdbeek commented Jan 15, 2020

The original seqtk recipe now has an additional patch ... perhaps that might be needed now too? https://github.com/bioconda/bioconda-recipes/blob/master/recipes/seqtk/meta.yaml#L12

@jmchilton
Copy link
Member

Might be better easier just patch fleeqtk if we think this is the problem.

@nsoranzo
Copy link
Member Author

I also see the fleeqtk seq hang during conda build locally. I've pushed a commit which changes the test a bit, seems to work for me.

@mvdbeek
Copy link
Member

mvdbeek commented Jan 15, 2020

Yeah, the additional patch doesn't make it a great example anymore. The original seqtk recipe builds fine, so let's patch fleeqtk

@jmchilton
Copy link
Member

If this doesn't fix things - lets cherry-pick this ( jmchilton@371f3d2 ) - I think that should build a new fleeqtk 1.4 with the patch applied.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that was it!

@jmchilton jmchilton merged commit 2b659c9 into galaxyproject:master Jan 15, 2020
@jmchilton
Copy link
Member

That was a long journey - thanks for the effort all!

@nsoranzo nsoranzo deleted the galaxy-tool-util branch January 15, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants