Skip to content

Replace galaxy-lib dependency with galaxy-tool-util.#1228

Merged
mr-c merged 1 commit intomasterfrom
galaxy-tool-util
Dec 25, 2019
Merged

Replace galaxy-lib dependency with galaxy-tool-util.#1228
mr-c merged 1 commit intomasterfrom
galaxy-tool-util

Conversation

@jmchilton
Copy link
Contributor

galaxy-lib is now unmaintained. We're managing the decomposition of the project from inside of the core codebase to prevent drift.

Fixes #1155

galaxy-lib is now unmaintained. We're managing the decomposition of the project from inside of the core codebase to prevent drift.
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #1228 into master will decrease coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   77.02%   76.99%   -0.03%     
==========================================
  Files          35       35              
  Lines        7217     7217              
  Branches     1853     1853              
==========================================
- Hits         5559     5557       -2     
- Misses       1185     1187       +2     
  Partials      473      473
Impacted Files Coverage Δ
cwltool/software_requirements.py 28.94% <25%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead263d...fd94699. Read the comment docs.

@jmchilton jmchilton changed the title [WIP] Replace galaxy-lib dependency with galaxy-tool-util. Replace galaxy-lib dependency with galaxy-tool-util. Dec 17, 2019
@jmchilton jmchilton requested a review from mr-c December 18, 2019 01:38
@mr-c mr-c merged commit efb40a8 into master Dec 25, 2019
@mr-c mr-c deleted the galaxy-tool-util branch December 25, 2019 19:21
@jmchilton
Copy link
Contributor Author

Thanks so much!

@jmchilton
Copy link
Contributor Author

@mr-c I'd try not to ping you this time of year but I have this paranoid vision of you breaking 2.7 compatibility like at 1am on January 1st as a little treat to yourself to start the decade 😆. If you do do that - just was hoping you'd do a final release that works with 2.7 including this. Thanks and happy new years!

@nsoranzo
Copy link

@jmchilton I think this is already included in cwltool 1.0.20191225192155 , already on PyPI.

@jmchilton
Copy link
Contributor Author

Crap - browser caching thing maybe, I don't know how I missed that. Sorry for the noise.

@mr-c
Copy link
Member

mr-c commented Dec 29, 2019

@jmchilton No worries, I had started the release process earlier today https://github.com/common-workflow-language/cwltool/releases/tag/1.0.20191225192155

Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace galaxy-lib requirement with galaxy-tool-util

3 participants