Lint only realized tools during shed linting.#628
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Feb 6, 2017
Merged
Lint only realized tools during shed linting.#628jmchilton merged 1 commit intogalaxyproject:masterfrom
jmchilton merged 1 commit intogalaxyproject:masterfrom
Conversation
Prevents each tool for being linted for every resolved repository and fixes galaxyproject#564. Sorry about that.
bgruening
reviewed
Feb 6, 2017
|
|
||
| def lint_tool_dependencies_urls(path, lint_ctx): | ||
| def lint_tool_dependencies_urls(realized_repository, lint_ctx): | ||
| path = realized_repository.real_path |
Member
There was a problem hiding this comment.
This had broken planemo:
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/planemo/shed_lint.py", line 200, in lint_tool_dependencies_urls
path = realized_repository.real_path
AttributeError: 'str' object has no attribute 'real_path'
Member
Author
There was a problem hiding this comment.
No test coverage for --urls it would seem - sorry about that @bgruening.
Member
There was a problem hiding this comment.
sorry for not fixing it myself, busy with the training here
jmchilton
added a commit
that referenced
this pull request
Feb 7, 2017
Thanks to @bgruening for the bug report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents each tool for being linted for every resolved repository and fixes #564.
Sorry about that.