Conversation
Member
|
I just added this though because I don't want to use Galaxy's default. Is there another way to fix this? |
Member
|
I reviewed 5e0b6d1 - I think we want this default but the |
Member
Author
|
I guess we could remove this line: https://github.com/galaxyproject/planemo/blob/fix_resolvers_conf/planemo/galaxy_config.py#L675 Not tested, but then the conda_prefix is also not added. |
Member
Author
|
Ok, will try this. |
Remove one of the two prefix="" attributes from the `resolvers_conf.xml` which results in this error:
```
File "/home/bag/projects/code/galaxy-test/lib/galaxy/tools/deps/__init__.py", line 44, in build_dependency_manager
dependency_manager = DependencyManager( **dependency_manager_kwds )
File "/home/bag/projects/code/galaxy-test/lib/galaxy/tools/deps/__init__.py", line 87, in __init__
self.dependency_resolvers = self.__build_dependency_resolvers( conf_file )
File "/home/bag/projects/code/galaxy-test/lib/galaxy/tools/deps/__init__.py", line 132, in __build_dependency_resolvers
plugin_source = plugin_config.plugin_source_from_path( conf_file )
File "/home/bag/projects/code/galaxy-test/lib/galaxy/util/plugin_config.py", line 74, in plugin_source_from_path
return ('xml', ElementTree.parse( path ).getroot())
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1182, in parse
tree.parse(source, parser)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 656, in parse
parser.feed(data)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
xml.etree.ElementTree.ParseError: duplicate attribute: line 2, column 66
```
8612a58 to
f7ed0d5
Compare
Member
Author
|
@jmchilton like this? |
Member
|
Yeah - does that work? |
Member
Author
|
Seems so! |
Member
Author
|
@jmchilton ok it works here: https://travis-ci.org/galaxyproject/tools-iuc/builds/102700945 The planemo error looks strange but this is an other problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove one of the two prefix="" attributes from the
resolvers_conf.xmlwhich results in this error: