Improving docker_shell#334
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Oct 20, 2015
Merged
Conversation
…) as well as mounting the tool directory and the current working directory.
Member
|
This is seems good, thanks. One question I'm not sure the answer - instead of using the fixed paths should we mount the volumes in specific places instead |
Contributor
Author
|
I'm mimicking the Galaxy behavior of mounting things to the same path inside the container. But that can be changed. Do you want it that way? |
Member
|
This is fine for now, it is simple and you are right - very much the naive approach of Galaxy. Thanks for these enhancements @kellrott they make a lot of sense to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the '-t' flag to the docker shell command (add psuedo terminal) as well as mounting the tool directory and the current working directory, also setting working directory for docker.