Enable GxITs in planemo serve#1568
Merged
mvdbeek merged 10 commits intogalaxyproject:masterfrom Mar 5, 2026
Merged
Conversation
Member
Author
|
Here it is. Thanks @bernt-matthias |
mvdbeek
reviewed
Oct 15, 2025
Member
There was a problem hiding this comment.
Thanks for working this out. I would make this the default with an option to disable interactive tools, planemo is for development, I don't think there's any harm in enabling ITs by default. However I would attempt binding a random gxit port, get_free_port in planemo.network_util can help you there.
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
65dfa62 to
11117c9
Compare
Member
Author
|
@mvdbeek is it ready? |
Member
|
Doesn't seem to work and it's conflicted. I'll find some time to look at this. |
mvdbeek
pushed a commit
to mvdbeek/planemo
that referenced
this pull request
Mar 2, 2026
Implement the changes from PR galaxyproject#1568: enable GxITs by default when running `planemo serve`, with a `--disable_gxits` flag to opt out. The gx_it_proxy port is dynamically allocated via get_free_port(). Add tests verifying: - GxITs are enabled by default with a valid port in galaxy.yml - Required Galaxy properties are set when GxITs are enabled - The --disable_gxits flag properly disables interactive tools - The galaxy_infrastructure_url respects host/port configuration https://claude.ai/code/session_011Pc8wpbxtD4A8Xp5E9c6Ld
11117c9 to
5866c9b
Compare
The previous GxIT implementation had broken conditional logic: disable_gxits defaulted to True (always disabling), used string "true"/"false" instead of booleans, had a conflicting enable_gxits check with a hardcoded port, and hardcoded "localhost" instead of using the host kwarg. Refactor write_galaxy_config to use a single clean if/else branch, proper boolean values, and the configured host. Move and rename the disable_interactive_tools option to disable_gxits_option. Add unit tests for GxIT enable/disable behavior and infrastructure URL construction.
5866c9b to
2ba5789
Compare
2ba5789 to
6494041
Compare
mvdbeek
approved these changes
Mar 4, 2026
Member
Author
|
thanks @mvdbeek we already have some users who need this :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is implemented as an option for the
servecommand. It can also be enabled by default if it is fine.