Add linter to check if tool versions are bumped#1502
Add linter to check if tool versions are bumped#1502mvdbeek merged 9 commits intogalaxyproject:masterfrom
Conversation
wrt toolshed
7c4d9cd to
ee39ad9
Compare
|
@bernt-matthias I suppose we need to disable the new |
|
Why is an equal version treated as an error? It should be equal if the latest code has just been pushed to the Tool Shed. |
See galaxyproject/planemo#1502 - in our current setup the the default branch should match the latest upload to the Tool Shed so the version number should be equal.
CI is executed before the push to the TS. The linter check is intended to check if the tool version has been increased in a pull request. CI does not do this nicely in some cases, eg if only one tool of a suite is updated. Therfore we allow to push anyway at IUC (after a careful double check). |
|
I guess the usefulness of the version equality check depends on the workflow and when planemo lint is run. I don’t think this should be the default, but can and have disabled this check entirely instead (not ideal as it won’t catch real errors out of sync). Thanks for clarifying |
so far against hardcoded toolshed.