Try to fix planemo test workflow when output is collection with identical name#1391
Merged
mvdbeek merged 2 commits intogalaxyproject:masterfrom Oct 6, 2023
Merged
Conversation
Don't love it but it'll do for now.
Author
|
Any idea why the test is not failing on CI? |
Member
|
It would have run in https://github.com/galaxyproject/planemo/actions/runs/6421040087/job/17434490532, but that was cancelled. |
Member
|
And yeah, it's failing locally for me too and my commit fixes this. |
Author
|
Great! |
Member
|
I think this is conda timing out, that probably needs to be fixed on the Galaxy or Conda side ... |
Author
|
Thanks for the fix. |
Member
|
Thanks for the test, that made it easy! |
mvdbeek
added a commit
to mvdbeek/planemo
that referenced
this pull request
Oct 26, 2023
The previous checksum is for an empty string. I think this has been wrong from the start because the code for downloading outputs was broken and only fixed in galaxyproject#1391
mvdbeek
added a commit
to mvdbeek/planemo
that referenced
this pull request
Oct 26, 2023
The previous checksum is for an empty string. I think this has been wrong from the start because the code for downloading outputs was broken and only fixed in galaxyproject#1391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See galaxyproject/iwc#225