Skip to content

Fix profile version test#1383

Merged
bernt-matthias merged 1 commit intogalaxyproject:masterfrom
bernt-matthias:topic/fix-profile-test
Aug 23, 2023
Merged

Fix profile version test#1383
bernt-matthias merged 1 commit intogalaxyproject:masterfrom
bernt-matthias:topic/fix-profile-test

Conversation

@bernt-matthias
Copy link
Collaborator

@bernt-matthias bernt-matthias commented Aug 23, 2023

linter has been adapted to new style profile versions and got a bit more relaxed.

galaxyproject/galaxy#16480

Alternatively we could work on the linter in Galaxy, e.g. something along:

try:
    profile_year, profile_month =  profile.split(".")
except Exception:
    handle_error
if int(profile_year) < 10:
    handle_error
if int(profile_year) < 23:
    if not profile_month in ["01", "02", "03", "04", ... ]:
        handle_error
else:
    if not re.match(profile_month, r"\d"):
        handle_error

@bernt-matthias
fix profile version test
e5626c5 
linter has been adapted to new style profile versions
and got a bit more relaxed.

galaxyproject/galaxy#16480
mvdbeek
mvdbeek approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bernt-matthias bernt-matthias merged commit 8795cac into galaxyproject:master Aug 23, 2023
@bernt-matthias bernt-matthias deleted the topic/fix-profile-test branch August 23, 2023 09:39
@mvdbeek mvdbeek changed the title fix profile version test Fix profile version test Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernt-matthias @mvdbeek