[23.0] Linter: fix regex for profile version#16480
Merged
dannon merged 2 commits intogalaxyproject:release_23.0from Jul 28, 2023
Merged
[23.0] Linter: fix regex for profile version#16480dannon merged 2 commits intogalaxyproject:release_23.0from
dannon merged 2 commits intogalaxyproject:release_23.0from
Conversation
mvdbeek
approved these changes
Jul 28, 2023
Member
mvdbeek
left a comment
There was a problem hiding this comment.
Looks good, but maybe target 23.0 ?
09cc2be to
a401bc9
Compare
c4c03a1 to
77c0e91
Compare
- did not allow for new style profile versions (that may have only a single digit after the dot) - fix: do not allow `,` in profile version
since in the past releases were quite irregular
|
This PR was merged without a "kind/" label, please correct. |
4 tasks
bernt-matthias
added a commit
to bernt-matthias/planemo
that referenced
this pull request
Aug 23, 2023
linter has been adapted to new style profile versions and got a bit more relaxed. galaxyproject/galaxy#16480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
,in profile versionHow to test the changes?
(Select all options that apply)
License