Fix extraction of orcid identifiers for .dockstore.yml#1350
Merged
mvdbeek merged 4 commits intogalaxyproject:masterfrom Feb 16, 2023
Merged
Fix extraction of orcid identifiers for .dockstore.yml#1350mvdbeek merged 4 commits intogalaxyproject:masterfrom
mvdbeek merged 4 commits intogalaxyproject:masterfrom
Conversation
Member
we could also check that on our side, I assume orcid is always going to be 16 ? |
Author
|
Now with the regex it should be ok. It was just that when I did a mistake with the regex it was passing while I was expecting to fail... Nevermind. I think this is the good solution, I just need to fix the test case. |
mvdbeek
approved these changes
Feb 16, 2023
Member
mvdbeek
left a comment
There was a problem hiding this comment.
I tried fixing up the tests, if that still looks good to you @lldelisle I will merge
Author
|
Thanks I forgot I was working on this. |
Author
|
One test failed and I don't have the power to rerun it. |
Member
|
The node download failed, bit of a problem recently, but nothign related to this PR |
Author
|
cool ! sorry that I needed 3 PR to make it work... |
Member
|
No worries, would've taken me the same amount of PRs, or more ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
def testso the dockstore with creator was not tested...Update author metadata in .dockstore.yml iwc#174 (comment)
But strangely, if you put a 16 numbers which does not match a real orcid to get 404 but if you put 15 or 17 numbers it gives 200 and bring you to the login page: