Merged
Conversation
mvdbeek
reviewed
Nov 3, 2022
mvdbeek
reviewed
Nov 3, 2022
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
…into add_creator_dockstore
mvdbeek
approved these changes
Nov 3, 2022
Author
|
@mvdbeek the test on dev local conda is still failing. |
Member
|
I think @nsoranzo figured out what's up with that. |
Member
|
Thanks, I'm excited to see this on dockstore! |
Author
|
Yes but that's why automerge did not work... |
Member
|
Amazing, amazing, amazing! Thanks so much - this is really cool. |
Member
I do have the fix for Galaxy dev, working on adding a test but got stuck in some test refactoring. Will open a PR later today, in a symposium at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to propagate creator info from workflows to dockstore.yml.
Feel free to modify the code because I am not super happy about it.