Round of Shed Related Improvements#134
Merged
jmchilton merged 10 commits intogalaxyproject:masterfrom Apr 24, 2015
Merged
Conversation
Good to introduce the logic and it was being used incorrectly in some places.
The biggest upshot here is that not now in source repositories package (tool_dependency_definition) and suite (repository_suite_definition) directories can now have readmes. The shed upload code will just quietly discard these.
Currently just creates .shed.yml files from command-line arguments. Arguably the tool author could just open this file and start editing but at least --help provides some sort guidance of what fields are available and validates categories for instance. The real reason to add this however is as a stepping stone toward galaxyproject#118.
Builds out a repository_dependencies.xml from the specified workflow. If needed, this also copies the workflow into the target repository. Closes galaxyproject#118.
Check restructured text if a README.rst is found. Warn the user if they have accidently used a README.md file. Otherwise just present INFO about the readme detected. Closes galaxyproject#91 Closes galaxyproject#89
This was referenced Apr 23, 2015
Member
|
👍 I love this tool! |
Not just ``with`` was just laziness on my part - thanks for catching that @bgruening :).
Member
Author
|
I have fixed the lazy file handling on my part and created an issue for thinking more about categories - thanks for the detailed review @bgruening! |
jmchilton
added a commit
that referenced
this pull request
Apr 24, 2015
Round of Shed Related Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details, but at a high-level:
shed_uploadto filter invalid files client side so tool dependency and suite repositories can contain README files with impunity.shed_initcommand for building.shed.ymlfiles and adds category validation toshed_lint.--from_workflowto the newshed_initcommand for quickly bootstrappingrepository_dependency.xmlfiles from workflows. Closes Generate repository_dependencies.xml from *.ga file(s) #118shed_lintclosing linting: Check for suitable README file #89 and linting: Check reStructuredText markup in any .rst files #91.