Fix workflow_lint with list + check elements in collection#1310
Merged
mvdbeek merged 6 commits intogalaxyproject:masterfrom Nov 2, 2022
Merged
Fix workflow_lint with list + check elements in collection#1310mvdbeek merged 6 commits intogalaxyproject:masterfrom
mvdbeek merged 6 commits intogalaxyproject:masterfrom
Conversation
Member
|
Yes, I think that's fine. |
Author
|
We ignore if tests are failing on the dev branch of galaxy right? |
Member
|
Yes, those failing tests are probably related to one of the recent conda changes in Galaxy. Looks like there are some problems with local conda channels. |
mvdbeek
approved these changes
Nov 2, 2022
Member
mvdbeek
left a comment
There was a problem hiding this comment.
That is super helpful, thank you so much @lldelisle!
Member
I tried to replicate this locally with: PYTEST_TARGET=tests/test_cmd_test_conda.py::CmdTestCondaTestCase::test_local_conda_dependencies_version tox -e py37-unit-nonredundant-noclientbuild-noshed-gx-devbut it passes for me even after removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve #1309
I would like to write tests. Should I make one directory per test with workflow and test file inside ? In the
tests/data/wf_repos?Thanks