Skip to content

[BUG] The new handling of the asserts section forgot a possible syntax #1309

@lldelisle

Description

@lldelisle

Hi,
One of the IWC workflow lint raise error because of this line:

for assertion_name, assertion_params in assertion_definitions.items():

See: https://github.com/galaxyproject/iwc/actions/runs/3357665520/jobs/5580414418

The tests responsible for the fail are:
https://github.com/galaxyproject/iwc/blob/fbdefc404c7abe8b9a4b5b8a2a4b25ad8f38ecb9/workflows/epigenetics/atacseq/atacseq-tests.yml#L113-L118

Indeed when specifying multiple tests of the same kind, the only way to have them all taken into account is this syntax.
This is documented here: https://github.com/galaxyproject/galaxy/blob/dev/test/functional/tools/simple_constructs.yml
And the parser code is here:
https://github.com/galaxyproject/galaxy/blob/d30b8659eebb38cc4aff1111d3549be043bf374d/lib/galaxy/tool_util/parser/yaml.py#L267-L292

Also, if we modify it, maybe it would be good to also lint the asserts in the elements of a collection but this may come in a second wave.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions