Skip to content

Bump galaxy package requirements to 22.01#1264

Merged
nsoranzo merged 4 commits intogalaxyproject:masterfrom
bernt-matthias:topic/22.01
Sep 20, 2022
Merged

Bump galaxy package requirements to 22.01#1264
nsoranzo merged 4 commits intogalaxyproject:masterfrom
bernt-matthias:topic/22.01

Conversation

@bernt-matthias
Copy link
Collaborator

and see what breaks

@bernt-matthias bernt-matthias force-pushed the topic/22.01 branch 2 times, most recently from 23beb17 to 9d844f6 Compare August 23, 2022 13:21
bernt-matthias added a commit to bernt-matthias/galaxy that referenced this pull request Aug 23, 2022
error introduced here galaxyproject#13186

found this while working on galaxyproject/planemo#1264
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@bernt-matthias
Copy link
Collaborator Author

Not sure yet what causes CmdAutoupdateTestCase.test_autoupdate_workflow to fail. Any idea?

The other two should be fixed by galaxyproject/galaxy#14496 .. I hope

@mvdbeek
Copy link
Member

mvdbeek commented Aug 23, 2022

That's galaxyproject/galaxy#14494

@bernt-matthias
Copy link
Collaborator Author

That's galaxyproject/galaxy#14494

Cool. But then we need to backport this PR to 22.01 or we wait for 22.05 and bump again.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 24, 2022

No, that is the refactoring action called within the Galaxy instance that planemo spins up.

Fix the following test failure:

```
___________________ LintTestCase.test_lint_dependencies_okay ___________________

self = <tests.test_lint.LintTestCase testMethod=test_lint_dependencies_okay>

    @skip_if_environ("PLANEMO_SKIP_SLOW_TESTS")
    def test_lint_dependencies_okay(self):
        seqtk_seq_v6 = os.path.join(PROJECT_TEMPLATES_DIR, "seqtk_complete", "seqtk_seq.xml")
        lint_cmd = ["lint", seqtk_seq_v6]
>       self._check_exit_code(lint_cmd)

tests/test_lint.py:105:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/test_utils.py:110: in _check_exit_code
    return check_exit_code(self._runner, command_list, exit_code=exit_code)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

runner = <click.testing.CliRunner object at 0x7f362c80ca10>
command_list = ['lint', '/home/runner/work/planemo/planemo/tests/../project_templates/seqtk_complete/seqtk_seq.xml']
exit_code = 0

    def check_exit_code(runner, command_list, exit_code=0):
        expected_exit_code = exit_code
        planemo_cli = cli.planemo
        if run_verbosely():
            print(f"Invoking command [{command_list}]")
        result = runner.invoke(planemo_cli, command_list)
        if run_verbosely():
            print(f"Command list output is [{result.output}]")
        result_exit_code = result.exit_code
        if expected_exit_code is NON_ZERO_EXIT_CODE:
            matches_expectation = result_exit_code != 0
        else:
            matches_expectation = result_exit_code == expected_exit_code
        if not matches_expectation:
            message = (
                f"Planemo command [{' '.join(command_list)}] resulted in unexpected exit code [{result_exit_code}], "
                f"expected exit code [{expected_exit_code}]]. Command output [{result.output}]"
            )
            if result.exception:
                message += f" Exception [{unicodify(result.exception)}], "
                exc_type, exc_value, exc_traceback = result.exc_info
                tb = traceback.format_exception(exc_type, exc_value, exc_traceback)
                message += f"Traceback [{tb}]"
            if run_verbosely():
                print(f"Raising assertion error for unexpected exit code [{message}]")
>           raise AssertionError(message)
E           AssertionError: Planemo command [lint /home/runner/work/planemo/planemo/tests/../project_templates/seqtk_complete/seqtk_seq.xml] resulted in unexpected exit code [1], expected exit code [0]]. Command output [Linting tool /home/runner/work/planemo/planemo/project_templates/seqtk_complete/seqtk_seq.xml
E           Applying linter tests... CHECK
E           .. CHECK: 1 test(s) found.
E           Applying linter output... CHECK
E           .. INFO: 1 outputs found.
E           Applying linter inputs... WARNING
E           .. WARNING: Conditional [sample] first param of type="boolean" is discouraged, use a select
E           .. INFO: Found 9 input parameters.
E           Applying linter help... CHECK
E           .. CHECK: Tool contains help section.
E           .. CHECK: Help contains valid reStructuredText.
E           Applying linter general... CHECK
E           .. CHECK: Tool defines a version [0.1.0].
E           .. CHECK: Tool defines a name [Convert to FASTA (seqtk)].
E           .. CHECK: Tool defines an id [seqtk_seq].
E           .. CHECK: Tool targets 16.01 Galaxy profile.
E           Applying linter command... CHECK
E           .. INFO: Tool contains a command.
E           Applying linter citations... CHECK
E           .. CHECK: Found 1 likely valid citations.
E           Applying linter tool_xsd... CHECK
E           .. INFO: File validates against XML schema.
E           Failed linting
E           ] Exception [1], Traceback [['Traceback (most recent call last):\n', '  File "/home/runner/work/planemo/planemo/planemo/cli.py", line 96, in handle_blended_options\n    return f(*args, **kwds)\n', '  File "/home/runner/work/planemo/planemo/planemo/commands/cmd_lint.py", line 65, in cli\n    ctx.exit(exit_code)\n', '  File "/home/runner/work/planemo/planemo/planemo/cli.py", line 40, in exit\n    raise ExitCodeException(exit_code)\n', 'planemo.exit_codes.ExitCodeException: 1\n', '\nDuring handling of the above exception, another exception occurred:\n\n', 'Traceback (most recent call last):\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/testing.py", line 408, in invoke\n    return_value = cli.main(args=args or (), prog_name=prog_name, **extra)\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/core.py", line 1055, in main\n    rv = self.invoke(ctx)\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/core.py", line 1657, in invoke\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/core.py", line 1404, in invoke\n    return ctx.invoke(self.callback, **ctx.params)\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/core.py", line 760, in invoke\n    return __callback(*args, **kwargs)\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/decorators.py", line 84, in new_func\n    return ctx.invoke(f, obj, *args, **kwargs)\n', '  File "/home/runner/work/planemo/planemo/.tox/py37-unit-nonredundant-noclientbuild-noshed/lib/python3.7/site-packages/click/core.py", line 760, in invoke\n    return __callback(*args, **kwargs)\n', '  File "/home/runner/work/planemo/planemo/planemo/cli.py", line 98, in handle_blended_options\n    sys.exit(e.exit_code)\n', 'SystemExit: 1\n']]

tests/test_utils.py:318: AssertionError
```
@nsoranzo nsoranzo merged commit 6d1c3f2 into galaxyproject:master Sep 20, 2022
@bernt-matthias bernt-matthias deleted the topic/22.01 branch September 21, 2022 06:27
@bernt-matthias
Copy link
Collaborator Author

Should we repeat thin for 22.05?

@mvdbeek mvdbeek changed the title bump requirements to 22.01 Bump galaxy package requirements to 22.01 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants