Skip to content

Fix container register for gh workflow#1135

Merged
nsoranzo merged 22 commits intogalaxyproject:masterfrom
mvdbeek:fix_container_register_for_gh_workflow
Jan 30, 2021
Merged

Fix container register for gh workflow#1135
nsoranzo merged 22 commits intogalaxyproject:masterfrom
mvdbeek:fix_container_register_for_gh_workflow

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 25, 2021

Continues #1133

@nsoranzo
Copy link
Member

mypy CI build is fixed in #1134 if you have time to review 😉

@mvdbeek mvdbeek force-pushed the fix_container_register_for_gh_workflow branch from 73d75f0 to db9865c Compare January 25, 2021 12:40
@mvdbeek mvdbeek force-pushed the fix_container_register_for_gh_workflow branch 2 times, most recently from 7648c86 to 48cc228 Compare January 25, 2021 12:46
@mvdbeek mvdbeek added the wip label Jan 25, 2021
@mvdbeek mvdbeek force-pushed the fix_container_register_for_gh_workflow branch from 48cc228 to 9d73d2d Compare January 25, 2021 14:23
... given the complexities of figuring out what the correct remote
should be maybe it's not worth making this configurable in the fork
function.
@mvdbeek mvdbeek force-pushed the fix_container_register_for_gh_workflow branch from af9b8af to db7126c Compare January 26, 2021 12:15
@mvdbeek mvdbeek force-pushed the fix_container_register_for_gh_workflow branch from e2134ec to 9c315e1 Compare January 26, 2021 14:41
@mvdbeek mvdbeek removed the wip label Jan 26, 2021
@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 26, 2021

Alright, this is working now

mvdbeek added a commit to galaxyproject/planemo-monitor that referenced this pull request Jan 26, 2021
@nsoranzo nsoranzo merged commit a3bbfa5 into galaxyproject:master Jan 30, 2021
@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 30, 2021

Thanks @nsoranzo!

@mvdbeek mvdbeek deleted the fix_container_register_for_gh_workflow branch January 31, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants