Tools don't start with <tool_dependencies#949
Merged
dannon merged 1 commit intogalaxyproject:devfrom Oct 20, 2015
Merged
Conversation
Tools start with '<tool '
hexylena
added a commit
to galaxyproject/planemo
that referenced
this pull request
Oct 20, 2015
hexylena
added a commit
to galaxyproject/planemo
that referenced
this pull request
Oct 20, 2015
Member
|
LGTM |
Member
|
👍 |
1 similar comment
Member
|
+1 |
dannon
added a commit
that referenced
this pull request
Oct 20, 2015
Tools don't start with <tool_dependencies
Member
|
The problem is that could be a tab or a newline or carriage return. Can we redo this and check that the line contains |
Member
|
Man I hate XML. Good call, though, @jmchilton |
Member
Author
|
@jmchilton yep, good point. I'll update with regex very shortly. |
hexylena
added a commit
to galaxyproject/planemo
that referenced
this pull request
Oct 20, 2015
jmchilton
added a commit
to galaxyproject/planemo
that referenced
this pull request
Oct 20, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools start with
'<tool 'not'<tool'.Please review thoroughly as I feel like this is an extremely important bit of code and if this change is incorrect, it could be pretty unpleasant for people. This one character change ensures that the only things picked up by
__looks_like_a_toolare actually tools and nottool_dependencies.xmlfiles which also have<toolin them.This will fix galaxyproject/planemo#313 as soon as planemo inherits this.