Skip to content

[20.01] Extended base annotation fixes#9224

Merged
jmchilton merged 1 commit intogalaxyproject:release_20.01from
mvdbeek:extended_base_aonnotation_fixes
Jan 16, 2020
Merged

[20.01] Extended base annotation fixes#9224
jmchilton merged 1 commit intogalaxyproject:release_20.01from
mvdbeek:extended_base_aonnotation_fixes

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 16, 2020

Sort best package by upload time (lowest priority) in addition to version and build number.

This is necessary for getting the extended-base annotation for qiime 1.9.1,
which does not contain the annotation in
linux-64/qiime-1.9.1-np110py27_1.tar.bz2 while in the newer
linux-64/qiime-1.9.1-np112py27_1.tar.bz2 it is present. This depends of course
on conda search returning packages sorted by upload time and is a little
brittle. It does seem better than always picking the oldest upload time as we
do without this change. Also looks in meta.yaml for extended base annotation,
since sometimes this isn't present in info/about.json.

in addition to version and build number. This is necessary for getting
the extended-base annotation for qiime 1.9.1, which does not contain the
annotation in linux-64/qiime-1.9.1-np110py27_1.tar.bz2 while in the
newer linux-64/qiime-1.9.1-np112py27_1.tar.bz2 it is present. This
depends of course on `conda search` returning packages sorted by upload
time and is a little brittle. It does seem better than always picking
the oldest upload time as we do without this change.  Also looks in
meta.yaml for extended base annotation, since sometimes this isn't
present in info/about.json.
@mvdbeek mvdbeek requested a review from bgruening January 16, 2020 11:00
@jmchilton jmchilton merged commit f8117b0 into galaxyproject:release_20.01 Jan 16, 2020
@jmchilton
Copy link
Member

I'll mint a new release!

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 16, 2020

Thanks!

@jmchilton
Copy link
Member

Done - thanks @mvdbeek !

mvdbeek added a commit to mvdbeek/planemo that referenced this pull request Jan 16, 2020
@nsoranzo nsoranzo deleted the extended_base_aonnotation_fixes branch January 16, 2020 15:04
@nsoranzo nsoranzo added this to the 20.01 milestone Jan 16, 2020
@galaxyproject galaxyproject deleted a comment from galaxybot Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants