[STABLE] Bugfixes for runtime parameter handling in the workflow run form.#84
Closed
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
Closed
[STABLE] Bugfixes for runtime parameter handling in the workflow run form.#84jmchilton wants to merge 1 commit intogalaxyproject:devfrom
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
Conversation
The behavior of these forms was modified in PR 433 (https://bitbucket.org/galaxy/galaxy-central/pull-request/433/fix-allow-editing-workflows-on-the-fly-for/diff# - not merged by me :| ) - so that the entire workflow would be submitted as runtime parameters on each submission. In addition to this causing bugs related to unvalidated parameters https://trello.com/c/72WuZ8mu and other problems with select parameters (e.g. http://dev.list.galaxyproject.org/Workflow-bug-when-loc-entries-are-missing-tc4666875.html) - I just discovered it would also cause the modified value to be submitted even if the user opts to undo the selection of a runtime workflow parameter and restore the previous selection (i.e. the form would show the original value but the new value would be submitted). This PR restores the previous behavior of giving the submitted form elements a unique name so every value in the workflow is not replaced as part of the submission - fixing the former problem. The new technique also fixes the other problem as well.
Member
Author
|
Mis-targeted branch. |
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Jan 24, 2017
Modify bioblend.galaxy.histories to implement TODOs, fix dataset URL by downloading from url provided by show_datasets() call
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Jan 24, 2017
Fix for galaxyproject#84 and documentation improvements
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Jan 24, 2017
OlegZharkov
referenced
this pull request
in OlegZharkov/galaxy
Oct 31, 2020
[upstream] merge upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of these forms was modified in PR 433 (https://bitbucket.org/galaxy/galaxy-central/pull-request/433/fix-allow-editing-workflows-on-the-fly-for/diff#) - so that the entire workflow would be submitted as runtime parameters on each submission.
In addition to this causing bugs related to unvalidated parameters https://trello.com/c/72WuZ8mu and other problems with select parameters (e.g. http://dev.list.galaxyproject.org/Workflow-bug-when-loc-entries-are-missing-tc4666875.html) - I just discovered it would also cause the modified value to be submitted even if the user opts to undo the selection of a runtime workflow parameter and restore the previous selection (i.e. the form would show the original value but the new value would be submitted).
This PR restores the previous behavior of giving the submitted form elements a unique name so every value in the workflow is not replaced as part of the submission - fixing the former problem. The new technique also fixes the problem of submitting the modified values even when the unmodified values are displayed.