Don't display outputs that aren't going to be produced in workflow editor#7466
Merged
jmchilton merged 4 commits intogalaxyproject:devfrom Mar 5, 2019
Merged
Conversation
This obviously doesn't work (yet) with filters that work on the input dataset, but this already removes a lot of outputs that arent' going to be produced based on static options. Since exceptions default to priduing the dataset this isn't much harm.
2e03a65 to
0bed645
Compare
Member
Author
Otherwise state inputs contain history datasets. This is a bug that might result in non-deterministic tool module behavior.
Member
|
Great idea, and way more concise to implement than I'd have thought. |
Member
Author
|
Yeah, I was also expecting that it might be harder than that ... |
e2d6479 to
5c521e1
Compare
Member
|
Marvelous! |
nsoranzo
reviewed
Mar 5, 2019
| Builds module models for the workflow editor. | ||
| """ | ||
| inputs = payload.get('inputs', {}) | ||
| trans.workflow_build_mode = workflow_building_modes.ENABLED |
Member
There was a problem hiding this comment.
@mvdbeek Did you mean trans.workflow_building_mode ?
Member
Author
There was a problem hiding this comment.
Exactly, and was half expecting this wouldn't work because we may also use this when building the workflow run form. Which it may not after all. Thanks for checking @nsoranzo !
nsoranzo
reviewed
Mar 5, 2019
| 'label', | ||
| ) | ||
|
|
||
| @skip_without_tool('output_filter') |
Member
There was a problem hiding this comment.
Suggested change
| @skip_without_tool('output_filter') | |
| @skip_without_tool('output_filter_with_input') |
| assert outputs[1]['name'] == 'out_2' | ||
| assert outputs[2]['name'] == 'out_3' | ||
|
|
||
| @skip_without_tool('output_filter_with_input') |
Member
There was a problem hiding this comment.
Suggested change
| @skip_without_tool('output_filter_with_input') | |
| @skip_without_tool('output_filter_exception_1') |
dannon
added a commit
that referenced
this pull request
Mar 22, 2019
[19.01] Backport #7466: Don't display outputs that aren't going to be produced in workflow editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This obviously doesn't work (yet) with filters that work on the input dataset, but this already removes a lot of outputs that are not going to be produced based on static options. Since exceptions default to producing the dataset this isn't much harm.