Skip to content

Add workflow step parameters to workflow editor - alternative.#6919

Closed
jmchilton wants to merge 19 commits intogalaxyproject:devfrom
jmchilton:workflow_step_parameters_2
Closed

Add workflow step parameters to workflow editor - alternative.#6919
jmchilton wants to merge 19 commits intogalaxyproject:devfrom
jmchilton:workflow_step_parameters_2

Conversation

@jmchilton
Copy link
Member

@jmchilton jmchilton commented Oct 24, 2018

UI for workflow step parameters - built on a slightly rebased version of #6829. Differences include:

  • Keep beta workflow modules config option, just move step parameters out of beta.
  • Rather than making all non-data parameters that are specified as RuntimeValue parameters - have separate states for RuntimeValue parameters and ConnectedValue parameters. I think this change is pretty isolated to 82cdbf3 if we want to undo it, I think on balance it is the right thing to do but I could be convinced I'm wrong I suspect.
  • Rather than defining "parameters" and "inputs" separately like in [WIP] Add workflow step parameters to workflow editor #6829, this brings in work from the CWL branch (standalone as Refactor collection mapping workflows toward independence from tools. #6911) to generalize inputs/outputs in the workflow module and API layer to non-data inputs. I like the consistency of this interface better and it starts us on the road to allow for complex field parameters in the CWL branch.

Use ConnectedValue values to determine what non-data parameters to display connections for.
Refactor get_data_inputs into get_all_inputs and use the resulting dictionaries to reason about if collection mapping should occur during invocation of tools. Using these dictionaries instead of explicit tool input objects should allow reuse within other module types since they may produce the same interface.
Don't treat data and non-data inputs/outputs different at the API boundary or at the workflow-manager.js level. Keep differences at the level of walking inputs/outputs in the workflow module on the backend and at the terminal definition (models and views) level on the frontend. Make the code and interfaces more consistent in my opinion and is more compatible with future directions I'd like to take things with mix-mode inputs/outputs for CWL.
Things not matching should be handled there.
@jmchilton jmchilton changed the title [WIP] Add workflow step parameters to workflow editor - alternative. Add workflow step parameters to workflow editor - alternative. Oct 25, 2018
@galaxybot galaxybot added this to the 19.01 milestone Oct 25, 2018
@jmchilton jmchilton closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants