Refactor collection mapping workflows toward independence from tools.#6911
Merged
mvdbeek merged 1 commit intogalaxyproject:devfrom Nov 5, 2018
Merged
Conversation
0a4d15f to
7be324b
Compare
Refactor get_data_inputs into get_all_inputs and use the resulting dictionaries to reason about if collection mapping should occur during invocation of tools. Using these dictionaries instead of explicit tool input objects should allow reuse within other module types since they may produce the same interface.
7be324b to
b1fe6fe
Compare
Member
Author
|
Here (6d7632e) you can see this refactoring enabling a nice simplification/unification of data and non-data parameters in the step parameter branch corresponding to #6919. And here (common-workflow-lab@7598bb5#diff-5cab48d5f01fec3fa30d17f4bf5d1848R22) you can see how it enables a bunch of features in the main CWL commit in that branch - defaults, expression inputs, field parameter types, etc.. |
This was referenced Oct 25, 2018
Member
|
@galaxybot test py3 |
mvdbeek
approved these changes
Nov 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor workflow module method
get_data_inputsintoget_all_inputsand use the resulting dictionaries to reason about if collection mapping should occur during invocation of tools. Using these dictionaries instead of explicit tool input objects should allow reuse within other module types since they may produce the same interface.