Skip to content

Show parameter name in DataToolParameter exception#5465

Merged
bgruening merged 1 commit intogalaxyproject:devfrom
peterjc:patch-5
Feb 11, 2018
Merged

Show parameter name in DataToolParameter exception#5465
bgruening merged 1 commit intogalaxyproject:devfrom
peterjc:patch-5

Conversation

@peterjc
Copy link
Contributor

@peterjc peterjc commented Feb 7, 2018

Goal is to replace this kind of output in a failed test run:

RunToolException: Error creating a job for these tool inputs - Specify a dataset of the required format / build.

with:

RunToolException: Error creating a job for these tool inputs - Specify a dataset of the required format / build in parameter 'XXX'.

Goal is to replace this kind of output in a failed test run:

RunToolException: Error creating a job for these tool inputs - Specify a dataset of the required format / build.

with:

RunToolException: Error creating a job for these tool inputs - Specify a dataset of the required format / build in parameter 'XXX'.
@galaxybot galaxybot added this to the 18.05 milestone Feb 7, 2018
@peterjc
Copy link
Contributor Author

peterjc commented Feb 7, 2018

Sample output where this could have been useful - although I think here my two data table parameters are either both going to work or both fail as their setup is basically the same:

https://travis-ci.org/peterjc/kodoja_galaxy/jobs/338504945
https://travis-ci.org/peterjc/kodoja_galaxy/jobs/338510306

peterjc added a commit to peterjc/kodoja_galaxy that referenced this pull request Feb 8, 2018
Official dev branch is broken for me,
galaxyproject/galaxy#5466

This branch adds some test debugging,
galaxyproject/galaxy#5465
peterjc added a commit to peterjc/kodoja_galaxy that referenced this pull request Feb 8, 2018
Official dev branch is broken for me,
galaxyproject/galaxy#5466

This branch adds some test debugging,
galaxyproject/galaxy#5465
peterjc added a commit to peterjc/kodoja_galaxy that referenced this pull request Feb 8, 2018
Official dev branch is broken for me,
galaxyproject/galaxy#5466

This branch adds some test debugging,
galaxyproject/galaxy#5465
@bgruening
Copy link
Member

Thanks @peterjc!

@bgruening bgruening merged commit 587f20c into galaxyproject:dev Feb 11, 2018
@peterjc peterjc deleted the patch-5 branch February 11, 2018 23:44
@peterjc
Copy link
Contributor Author

peterjc commented Feb 11, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants