Skip to content

Add RData and RData.gz formats#239

Merged
jmchilton merged 2 commits intogalaxyproject:devfrom
hexylena:rdata2
May 8, 2015
Merged

Add RData and RData.gz formats#239
jmchilton merged 2 commits intogalaxyproject:devfrom
hexylena:rdata2

Conversation

@hexylena
Copy link
Member

@hexylena hexylena commented May 7, 2015

RData has a wide array of formats, some more useful than others. There's the binary RData format which can optionally be gzipped. Then there's an ascii version of that which only holds a single variable (which we ignore).

http://biostat.mc.vanderbilt.edu/wiki/Main/RBinaryFormat
http://stackoverflow.com/a/21370351

@jmchilton
Copy link
Member

Can you stick a file_ext = 'rdata' on the implementation class?

Also - I don't think Galaxy is really going to like have two implementation of the same short extension - is that intentional? If yes, can you just have one class represent both "flavors" or RData - maybe storing whether it is compressed or not as a metadata element. If no, can you give them different extensions on the class and when registering them with Binary.

@hexylena
Copy link
Member Author

hexylena commented May 7, 2015

@jmchilton, sure, those all sound like good suggestions!

@hexylena
Copy link
Member Author

hexylena commented May 7, 2015

@jmchilton okay, just merged them into one datatype. I mostly added the second "just because". They're do the same thing, and library reading one will read the other, so I didn't bother with metadata elements either.

@jmchilton
Copy link
Member

Awesome - thanks. 👍

@natefoo
Copy link
Member

natefoo commented May 7, 2015

+1

@bgruening
Copy link
Member

Nice work! 👍

jmchilton added a commit that referenced this pull request May 8, 2015
Add RData and RData.gz formats
@jmchilton jmchilton merged commit f7af19b into galaxyproject:dev May 8, 2015
@hexylena
Copy link
Member Author

hexylena commented May 8, 2015

Thanks @jmchilton

@hexylena hexylena deleted the rdata2 branch June 17, 2015 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants