Skip to content

[WIP] Nose update with --debug option added to run_tests#172

Merged
dannon merged 4 commits intogalaxyproject:devfrom
dannon:testing_updates
Apr 29, 2015
Merged

[WIP] Nose update with --debug option added to run_tests#172
dannon merged 4 commits intogalaxyproject:devfrom
dannon:testing_updates

Conversation

@dannon
Copy link
Member

@dannon dannon commented Apr 27, 2015

No description provided.

@jmchilton
Copy link
Member

This nose update breaks planemo testing - I am looking into the planemo part of that but it abuses nose data structures in similar ways to the tool shed install and test framework - that is a greater concern in my mind.

@dannon
Copy link
Member Author

dannon commented Apr 27, 2015

Ach, yeah, I was focused on the Galaxy side. I'll try the shed tests.

@jmchilton
Copy link
Member

Unfortunately there are no tests for the install and test framework (https://trello.com/c/VHGB33Xp).

@dannon
Copy link
Member Author

dannon commented Apr 27, 2015

Yeaaah, this breaks more than I expected. I was exclusively testing against the broken API tests that got me started going down this road. Updating title with WIP to keep plugging at it without a merge.

@dannon dannon changed the title Nose update with --debug option added to run_tests [WIP] Nose update with --debug option added to run_tests Apr 27, 2015
@jmchilton
Copy link
Member

Okay - actually and luckily it seems the IPluginInterface has remained pretty stable - so perhaps we don't have to worry so much about the install and test framework. The problem I encountered in planemo is due to XUnit plugin upgrades - and the tool shed does not use the xunit report.

Previously the XUnit report looked like this:

<?xml version="1.0" encoding="UTF-8"?><testsuite name="nosetests" tests="1" errors="0" failures="0" skip="0"><testcase classname="functional.test_toolbox.TestForTool_cat" name="functional.test_toolbox.TestForTool_cat.test_tool_000000" time="13" /></testsuite>

Now it looks like this:

<?xml version="1.0" encoding="UTF-8"?><testsuite name="nosetests" tests="1" errors="0" failures="0" skip="0"><testcase classname="functional.test_toolbox.TestForTool_cat" name="test_tool_000000" time="11.776"></testcase></testsuite>

Planemo just needs to do a better job parsing the class name and name together when building its report.

If you give me a day to upgrade Planemo and do a new release - I will happily 👍 this as it stands.

@dannon
Copy link
Member Author

dannon commented Apr 27, 2015

No rush at all, sure.

jmchilton added a commit to galaxyproject/planemo that referenced this pull request Apr 27, 2015
@jmchilton
Copy link
Member

👍

dannon added a commit that referenced this pull request Apr 29, 2015
[WIP] Nose update with --debug option added to run_tests
@dannon dannon merged commit b3596d5 into galaxyproject:dev Apr 29, 2015
@dannon dannon deleted the testing_updates branch April 29, 2015 13:30
hechth pushed a commit to hechth/galaxy that referenced this pull request Jul 15, 2023
* updated jupyter ML interactive

* docker from quay.io

* add comment about disabling announcements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants