Merged
Conversation
…earch Follow-up on galaxyproject#13509 .
Rework `best_search_result()` and `CondaInDockerContext` to use it.
…rch()`
The `conda` package on PyPI is severely outdated and unmaintained, and
the output of `run_command("search", ...)` did not parse correctly.
Fix broken `test_conda_search` unit test.
Member
|
Thank you @nsoranzo! |
jmchilton
reviewed
Mar 14, 2022
nsoranzo
added a commit
to nsoranzo/planemo
that referenced
this pull request
Apr 1, 2022
In galaxyproject/galaxy#13532 I've removed the `channels_override` parameter from the `best_search_result()` method in galaxy-tool-util.
mvdbeek
added a commit
that referenced
this pull request
Apr 4, 2022
…364a20835acf16ccdffea3018a58023e2d [21.05] Partially backport #13532 to fix `test_github_search` mulled unit test
nsoranzo
added a commit
to nsoranzo/planemo
that referenced
this pull request
Apr 19, 2022
In galaxyproject/galaxy#13532 I've removed the `channels_override` parameter from the `best_search_result()` method in galaxy-tool-util.
nsoranzo
added a commit
to nsoranzo/planemo
that referenced
this pull request
Apr 19, 2022
In galaxyproject/galaxy#13532 I've removed the `channels_override` parameter from the `best_search_result()` method in galaxy-tool-util.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHubSearch. Deprecateget_json()search.Follow-up on Add retries to
test_github_search#13509 .CondaSearchto usecondafrom PATH and a newCondaContext.exec_search()methodThe
condapackage on PyPI is severely outdated and unmaintained, and the output ofrun_command("search", ...)did not parse correctly.best_search_result()andCondaInDockerContextto useCondaContext.exec_search().test_conda_searchunit test.How to test the changes?
(Select all options that apply)
License