Skip to content

Improved checking of workflow state at import.#1284

Closed
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
jmchilton:workflow_validation_0
Closed

Improved checking of workflow state at import.#1284
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
jmchilton:workflow_validation_0

Conversation

@jmchilton
Copy link
Member

Test case fails without the added check_param check in check_and_update_param_values/check_and_update_param_values_helper.

@nsoranzo
Copy link
Member

Seems to break many API tests.

@jmchilton
Copy link
Member Author

This does seem to break a lot of stuff 😦, not good this is pretty important. I think I have a downstream fix in the CWL branch that will address the same problem a little later in the workflow process the datasets will be connected and full validation can be performed.

@jmchilton jmchilton closed this Dec 10, 2015
jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 11, 2015
Do a more complete validation of everything after workflow parameters have been replaced and inputs connected up.

Attempt 2 at the idea in galaxyproject#1284.
jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 11, 2015
Do a more complete validation of everything after workflow parameters have been replaced and inputs connected up.

Attempt 2 at the idea in galaxyproject#1284.
jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 13, 2015
Do a more complete validation of everything after workflow parameters have been replaced and inputs connected up.

Attempt 2 at the idea in galaxyproject#1284.
jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 14, 2015
Do a more complete validation of everything after workflow parameters have been replaced and inputs connected up.

Attempt 2 at the idea in galaxyproject#1284.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants