Conversation
Move styles to css Improve handling of numeric workflow parameters
Fix comment
Improve readability
Fix style
…workflow_form_004
…workflow_form_004
There was a problem hiding this comment.
Can you catch a more specific exception here an add comment about the $.
c43bded to
8919386
Compare
|
There are three failing API tests that seem like legimate regressions. https://jenkins.galaxyproject.org/job/docker-api/1494/#showFailuresLink |
Catch missing history, fix failing api test
562bae2 to
ab651fa
Compare
f436486 to
00452e1
Compare
|
Thanks for looking into it. |
…workflow_form_004
9d37b35 to
07d989b
Compare
07d989b to
2b63427
Compare
85c8068 to
9a4c834
Compare
|
@guerler we need a rebase here and have 4 failing tests. |
|
@galaxybot test this |
Usability feels very good! Great work Aysam! Anyone wants to test it? Use this prepared Docker Image: |
|
@guerler This is the fix for the conflict. I tried to create a PR against your branch but because it is way behind dev (and in conflict :D) it caused trouble so I am sending it at least like this. guerler@3eef069#diff-fae872b63d46cbf39f4d2749c699f8e0R12 The whole thing with |
|
Also I am getting when trying to access the WF run form (no matter if the dev-merged version or @guerler's) |
|
@guerler and I discussed this and have decided to mirror the effort of the new tool form (keeping it optional by default initially). We will merge this today (for the exposure and because "97 changed files with 1,374 additions and 1,219 deletions." stales quickly) and then create an issue with things that need to be done before this can be the primary workflow form. |
Broken in commit 458766b from PR galaxyproject#1249.
This is the first PR for implementing and prepping the form classes to accommodate the new run workflow form. The new form is disabled by default (run_workflow_toolform_upgrade).