Skip to content

Run workflow form#1249

Merged
jmchilton merged 31 commits intogalaxyproject:devfrom
guerler:run_workflow_form_004
Dec 14, 2015
Merged

Run workflow form#1249
jmchilton merged 31 commits intogalaxyproject:devfrom
guerler:run_workflow_form_004

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Dec 6, 2015

This is the first PR for implementing and prepping the form classes to accommodate the new run workflow form. The new form is disabled by default (run_workflow_toolform_upgrade).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you catch a more specific exception here an add comment about the $.

@guerler guerler force-pushed the run_workflow_form_004 branch 2 times, most recently from c43bded to 8919386 Compare December 6, 2015 07:35
@jmchilton
Copy link
Member

There are three failing API tests that seem like legimate regressions. https://jenkins.galaxyproject.org/job/docker-api/1494/#showFailuresLink

Catch missing history, fix failing api test
@guerler guerler force-pushed the run_workflow_form_004 branch from 562bae2 to ab651fa Compare December 6, 2015 15:48
@guerler guerler force-pushed the run_workflow_form_004 branch from f436486 to 00452e1 Compare December 6, 2015 17:40
@guerler
Copy link
Contributor Author

guerler commented Dec 6, 2015

Thanks for looking into it.

@guerler guerler force-pushed the run_workflow_form_004 branch 2 times, most recently from 9d37b35 to 07d989b Compare December 8, 2015 17:01
@guerler guerler force-pushed the run_workflow_form_004 branch from 07d989b to 2b63427 Compare December 8, 2015 21:39
@bgruening
Copy link
Member

@guerler we need a rebase here and have 4 failing tests.

@martenson
Copy link
Member

@galaxybot test this
The 4 failing TS tests are unrelated to this PR, they should be fixed with this run.
edit: not fixed by rerun but definitely unrelated

@bgruening
Copy link
Member

  • it would be nice if the entire tool-header would be click able and open/close a tool
  • on a large screen the tools are on the right side of the main frame ... center or justify would be nice
  • on the other hand, now that we have more space left and right to the tool boxes, some arrows left and right indicating from which input belongs to which output would be great

Usability feels very good! Great work Aysam!

Anyone wants to test it? Use this prepared Docker Image:

docker run -p 8080:80 -i -t bgruening/galaxy-stable:guerler

@martenson
Copy link
Member

@guerler This is the fix for the conflict. I tried to create a PR against your branch but because it is way behind dev (and in conflict :D) it caused trouble so I am sending it at least like this.

guerler@3eef069#diff-fae872b63d46cbf39f4d2749c699f8e0R12

The whole thing with dev merged is in https://github.com/martenson/galaxy/commits/fix-js-imports (the fix-js-imports branch)

@martenson
Copy link
Member

Also I am getting

File '/Users/marten/devel/git/galaxy/database/compiled_templates/workflow/run.mako.py', line 91 in render_body
  step_model[ 'step_id' ] = step.id
TypeError: 'NoneType' object does not support item assignment

when trying to access the WF run form (no matter if the dev-merged version or @guerler's)
What am I doing wrong?

@jmchilton
Copy link
Member

@guerler and I discussed this and have decided to mirror the effort of the new tool form (keeping it optional by default initially). We will merge this today (for the exposure and because "97 changed files with 1,374 additions and 1,219 deletions." stales quickly) and then create an issue with things that need to be done before this can be the primary workflow form.

@martenson
Copy link
Member

@jmchilton 👍

jmchilton added a commit that referenced this pull request Dec 14, 2015
@jmchilton jmchilton merged commit e838b03 into galaxyproject:dev Dec 14, 2015
nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Dec 15, 2015
@guerler guerler mentioned this pull request Dec 16, 2015
@guerler guerler deleted the run_workflow_form_004 branch December 17, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants