[STABLE] Fix job file stageout interruptibility#110
Merged
jmchilton merged 2 commits intogalaxyproject:release_15.03from Apr 10, 2015
Merged
[STABLE] Fix job file stageout interruptibility#110jmchilton merged 2 commits intogalaxyproject:release_15.03from
jmchilton merged 2 commits intogalaxyproject:release_15.03from
Conversation
api. Moving is a rename when the source and destination are on the same filesystem, which is nearly instantaneous and greatly reduces the possibility for failure due to mid-copy restarts.
Member
|
👍 |
Member
|
Fix - huh? I think you may be pulling a Blankenberg :). Nonetheless 👍 |
jmchilton
added a commit
that referenced
this pull request
Apr 10, 2015
[STABLE] Fix job file stageout interruptibility
Member
Author
Shhhhhh. |
Member
|
Hey, wait, I uh...ok.. |
Member
There was a problem hiding this comment.
We broke non-nginx uploads here. The files got lost in the endpoint description.
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
May 5, 2015
Fixes regressions introduced with PR galaxyproject#110.
natefoo
added a commit
to natefoo/galaxy
that referenced
this pull request
May 6, 2015
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Jan 24, 2017
Rename input_ids and output_ids Workflow attributes to source_ids and sink_ids respectively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job files api is used by Pulsar when Pulsar is configured to initiate staging operations on the remote end. Without the upload module, restarting processes while a stageout is occurring can result in job failure (or possibly retrying the stageout from the beginning, a costly operation when the file is large).
Additionally, the staged out files are moved from their temporary received paths to their final destinations. This prevents the temporary space from growing excessively large and also causes the move to be instantaneous source and destination are on the same filesystem.
Here is the corresponding nginx config:
The nginx config should work if you have set the following in
galaxy.ini:Despite the warnings on IfIsEvil, this use of
ifin the nginx config appears to be safe.Related trello card: https://trello.com/c/usD7jzcT