fix: raise error when audio recording URL is inaccessible (TH-4734)#216
Merged
KarthikAvinashFI merged 1 commit intodevfrom May 5, 2026
Merged
Conversation
b72da3c to
b25a51f
Compare
b25a51f to
e476617
Compare
When detect_input_type returns 'file' for a URL with audio extension (.wav, .mp3, etc.), raise a user-facing ValueError instead of silently passing the URL as plain text to the LLM. This prevents meaningless eval results when recording URLs are not accessible.
e476617 to
214625f
Compare
atharva-bhange
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise a user-facing error when an audio recording URL is not accessible, instead of silently treating it as text.
Problem
When external audio URLs return 403/inaccessible,
detect_input_type()returns'file'. Since'file'is not in_SUPPORTED_MEDIA, the URL passes through as plain text to the LLM — producing meaningless eval results.Fix
In the shared media detection path (
llm_payloads.py), when type is'file'and URL has an audio extension (.wav, .mp3, etc.), raise:Test plan