Check resumable state machine MemberwiseClone setting incorrect state on multiple iterations #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbded22 to
1eeaa5a
Compare
abelbraaksma
added a commit
that referenced
this pull request
Oct 17, 2022
…erations comes from TaskSeq<_>.GetAsyncEnumerator
abelbraaksma
added a commit
that referenced
this pull request
Oct 17, 2022
…erations comes from TaskSeq<_>.GetAsyncEnumerator
abelbraaksma
added a commit
that referenced
this pull request
Oct 17, 2022
…erations comes from TaskSeq<_>.GetAsyncEnumerator
a4cf0ec to
9473460
Compare
…is, partially fixed Issue has to do with the MemberwiseClone() for shadowing the enumerator is not enough to reset the necessary states. Furthermore, after this is sorta fixed, the ValueTask that is used to keep the MoveNext boolean gets accessed twice asynchronously, which is not allowed. It also seems that using 'use' on the taskSeq.GetAsyncEnumerator fails by double disposing. This can probably be considered "by design" but should carefully be considered.
6 tasks
Member
Author
|
This PR continues here: #42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39
If you create a
taskSeqand iterate over it multiple times this should be safe (certainly, there could be a backing of a forward-only stream, but in essence, the wrapper forIAsyncEnumerableprovided byTaskSeq<...>inTaskBuilder.fsshould on itself be safe to use multiple times).GetAsyncEnumerator, theelsepath)Not unimportant: the
TaskSeqmodule utility functions that use hand-written enumeration code appear to be sound. The ones that usetaskSequnder the hood are not. And when used with anIAsyncEnumerablecreated withtaskSeq, they fail, because of this ☝️.