Conversation
0735e7f to
b5522a9
Compare
Create a new watches type to keep track of the watches instead of keeping two maps on the Watcher and accessing these directly. This makes the bookkeeping a bit easier to follow, and we no longer need to worry about locking map access as the watcher type takes care of that now. Came up in #472 where I want to keep track if a path was added recursively, and this makes that a bit easier. Also seems a bit faster: BenchmarkWatch-2 903709 7122 ns/op 194 B/op 3 allocs/op BenchmarkWatch-2 923980 6322 ns/op 196 B/op 3 allocs/op Although that benchmark is very simply and only tests one code path; just want to make sure it's not a horrible regression.
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
arp242
added a commit
that referenced
this pull request
Apr 27, 2024
This simplifies things quite a bit. Previous: #543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new watches type to keep track of the watches instead of keeping two maps on the Watcher and accessing these directly.
This makes the bookkeeping a bit easier to follow, and we no longer need to worry about locking map access as the watcher type takes care of that now.
Came up in #472 where I want to keep track if a path was added recursively, and this makes that a bit easier.
Also seems a bit faster:
Although that benchmark is very simple and only tests one code path; just want to make sure it's not a horrible regression.