[bugfix] close handle when remWatch open in getIno#288
Merged
arp242 merged 2 commits intofsnotify:mainfrom Jul 31, 2022
Merged
Conversation
Code0x58
previously approved these changes
Apr 11, 2019
Contributor
Code0x58
left a comment
There was a problem hiding this comment.
Looks good to me. Would this be an excuse for a windows_test.go?
nathany
reviewed
Oct 5, 2019
Contributor
nathany
left a comment
There was a problem hiding this comment.
Thanks.
I'm not sure if we can add a test case around this issue. What do you think?
Member
|
@brokenjacky Would you update this? |
f8445c9 to
9936dc0
Compare
arp242
pushed a commit
to brokenjacky/fsnotify
that referenced
this pull request
Jul 22, 2022
Member
|
I rebased this on the latest main and I added the test case you wrote @mattn; is that test case finished or were you still working on it? |
9936dc0 to
e929749
Compare
Note: the tests pass even without the syscall.CloseHandle()
e929749 to
c3153fe
Compare
arp242
approved these changes
Jul 31, 2022
arp242
added a commit
that referenced
this pull request
Jul 12, 2023
Add test for remWatch, which #288 fixed. Co-authored-by: jie <jie@tt.com> Co-authored-by: Nahum Shalman <nahamu@gmail.com> Co-authored-by: Martin Tournoij <martin@arp242.net>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
when i remWatch a directory using remWatch, and then delete the directory ,and i find the directory is still in there but i can't access because a handle is still open
Where should the reviewer start?
How should this be manually tested?
see #42 ,the gist by timshannon (https://gist.github.com/timshannon/603f92824c5294269797)