only run golint on latest version of go#284
Merged
nathany merged 3 commits intofsnotify:masterfrom Mar 8, 2019
Merged
Conversation
de1bbf2 to
1b229aa
Compare
nathany
approved these changes
Mar 8, 2019
| - go test --race ./... | ||
|
|
||
| after_script: | ||
| - test -z "$(gofmt -s -l -w . | tee /dev/stderr)" |
Contributor
There was a problem hiding this comment.
This looks good. Thanks Brian!
It does make me wonder if we need to run gofmt or go vet on anything but the stable release too, but for now it doesn't hurt.
Contributor
|
Thanks @cpuguy83. Two questions:
|
Contributor
|
I've removed AppVeyor. This is the appveyor.yml export in case we ever need to bring it back. I will remove the badge shortly. |
Contributor
Author
|
Yes, I've signed the Google CLA, FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Where should the reviewer start?
Does CI pass?
Does golint run on go1.12?
How should this be manually tested?
N/A
Fixes #275
Closes #271