Skip to content

Fix formatting bug for zero value Quantities#505

Merged
shsms merged 2 commits intofrequenz-floss:v0.x.xfrom
shsms:formatting-bug
Jul 12, 2023
Merged

Fix formatting bug for zero value Quantities#505
shsms merged 2 commits intofrequenz-floss:v0.x.xfrom
shsms:formatting-bug

Conversation

@shsms
Copy link
Contributor

@shsms shsms commented Jul 11, 2023

Also add tests for zero and negative values.

This is already part of a patch release v0.22.1. Merging from v0.22.x to v0.x.x was a bit complicated, because of conflicts in the RELEASE_NOTES.md file, so making an independent PR.

shsms added 2 commits July 11, 2023 17:49
Also add tests for zero and negative values.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms shsms requested a review from a team as a code owner July 11, 2023 15:56
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:data-pipeline Affects the data pipeline labels Jul 11, 2023
@shsms shsms changed the title Fix formatting bug for zero values Fix formatting bug for zero value Quantities Jul 11, 2023
Copy link
Contributor

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Many thanks

@shsms shsms added this pull request to the merge queue Jul 12, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit 0e884b7 Jul 12, 2023
@shsms shsms deleted the formatting-bug branch July 12, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Percentage.from_percent(0).__str__() raising exception due to math.log10(0)?

2 participants