Support repo-config v0.9 properly#218
Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom Mar 12, 2024
Merged
Conversation
This was referenced Mar 12, 2024
Marenz
reviewed
Mar 12, 2024
Marenz
reviewed
Mar 12, 2024
Contributor
Marenz
left a comment
There was a problem hiding this comment.
Without the labeler update this will break labeling after merge.
Also I notice you didn't add the fix to have git-support in pyproject for the test-installation ci job.
Which isn't a problem as long as git-urls are not used as repository dependencies..
Here is the patch in question:
patch -p1 <<'EOF'
diff --git a/.github/containers/test-installation/Dockerfile b/.github/containers/test-installation/Dockerfile
index 772b2ae..2494545 100644
--- a/.github/containers/test-installation/Dockerfile
+++ b/.github/containers/test-installation/Dockerfile
@@ -6,7 +6,12 @@
FROM --platform=${TARGETPLATFORM} python:3.11-slim
-RUN python -m pip install --upgrade --no-cache-dir pip
+RUN apt-get update -y && \
+ apt-get install --no-install-recommends -y \
+ git && \
+ apt-get clean && \
+ rm -rf /var/lib/apt/lists/* && \
+ python -m pip install --upgrade --no-cache-dir pip
COPY dist dist
RUN pip install dist/*.whl && \
EOF
This repo recently moved to repo-config v0.9. While the dependabot PR for the upgrade passed, the release notes for repo-config suggest more changes. This commit tries to add these additional requirements for repo-config v0.9 upgrade. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
3ad2244 to
0d15bd9
Compare
Contributor
Author
It is because there is no test-installation step for this repo (which is by intention), so this step does not apply here. |
Marenz
approved these changes
Mar 12, 2024
llucax
reviewed
Mar 27, 2024
| # For more details read: | ||
| # https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ | ||
| uses: actions/labeler@ac9175f8a1f3625fd0d4fb234536d26811351594 # 4.3.0 | ||
| uses: actions/labeler@v5.0.0 |
Contributor
There was a problem hiding this comment.
We should use the hash here for security reasons.
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo recently moved to repo-config v0.9. While the dependabot PR for the upgrade passed, the release notes for repo-config suggest more changes. This commit tries to add these additional requirements for repo-config v0.9 upgrade.