Skip to content

Add relays and precharge components#104

Merged
tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz:relays
Aug 14, 2023
Merged

Add relays and precharge components#104
tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz:relays

Conversation

@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor

@tiyash-basu-frequenz tiyash-basu-frequenz commented Aug 10, 2023

This PR add support for two new components to the Microgrid API:

  • Relay
  • Precharge Module

@tiyash-basu-frequenz tiyash-basu-frequenz added this to the v0.16.0 milestone Aug 10, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz self-assigned this Aug 10, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz requested a review from a team as a code owner August 10, 2023 16:19
@github-actions github-actions Bot added part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files labels Aug 10, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz force-pushed the relays branch 2 times, most recently from f5f31e0 to 3522599 Compare August 10, 2023 16:20
@tiyash-basu-frequenz tiyash-basu-frequenz force-pushed the relays branch 2 times, most recently from 711e953 to c0229ce Compare August 10, 2023 16:28
Copy link
Copy Markdown
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it looks like #103 should be merged first, right? As the release notes mention StartComponent / StopComponent but the code still uses Start and Stop.

@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor Author

LGTM but it looks like #103 should be merged first, right?

Right, that's the plan. That's why I did not enable auto-merge in these PRs, because I was going to pull these manually.

@tiyash-basu-frequenz tiyash-basu-frequenz added the status:blocked Other issues must be resolved before this can be worked on label Aug 11, 2023
@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor Author

Marked blocked until #103 is merged.

Copy link
Copy Markdown
Contributor

@TalweSingh TalweSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve now since it's just a nitpick.

Comment thread proto/frequenz/api/microgrid/precharge_module.proto Outdated
Comment thread proto/frequenz/api/microgrid/relay.proto Outdated
@tiyash-basu-frequenz tiyash-basu-frequenz removed the status:blocked Other issues must be resolved before this can be worked on label Aug 11, 2023
@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor Author

#103 is merged. Unblocked this PR.

Comment thread proto/frequenz/api/microgrid/microgrid.proto
Relays are electromagnetic switches that control circuit breakers in the
microgrid, e.g., to connect or disconnect an inverter from the grid.

This commit allows clients to expect data for such relays in a microgrid,
and invoke the following commands:
  - `StartComponent`
  - `StopComponent`

Note that the relay.Relay message does not have `properties` or `data`.
`state` and `errors` should be enough to capture the information we need.

Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Precharging a DC (Direct Current) bus refers to a controlled process in
electrical systems, e.g., when connecting an inverter to a battery, where
the voltage across a DC bus is gradually increased from a low level to a
desired level before connecting a load or initiating normal operation.
This process is primarily used to prevent sudden surges of current that
can occur when a load is directly connected to a high-voltage DC source.

This commits adds support for interacting with precharge modules to the
Microgrid API. Clients can expect data from such components, and can
invoke the following RPCs:
  - `StartComponent`
  - `StopComponent`

Note that the precharge_module.PrechargeModule message does not have
`properties` or `data`. `state` and `errors` should be enough to capture
the information we need.

Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
@tiyash-basu-frequenz tiyash-basu-frequenz added this pull request to the merge queue Aug 14, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit df769a0 Aug 14, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz deleted the relays branch August 14, 2023 11:21
@tiyash-basu-frequenz tiyash-basu-frequenz removed this from the v0.16.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new component category Precharge Add support for new component category Relay

4 participants