Rename RPCs that act on Components#103
Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom Aug 11, 2023
Merged
Rename RPCs that act on Components#103tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
b770798 to
af994de
Compare
|
What about |
af994de to
0d29dc3
Compare
Contributor
Author
Was missing in the docs. Thanks for pointing out. Added. |
matthias-wende-frequenz
previously approved these changes
Aug 10, 2023
llucax
reviewed
Aug 11, 2023
Previously, these RPCs did not specify that these act on Components, which was a critical feature of these RPCs. This change adds `Component` to these RPCs, making them easier to read. Here are the details of the RPCs that got renamed: `AddExclusionBounds` -> `AddComponentExclusionBounds` `AddInclusionBounds` -> `AddComponentInclusionBounds` `SetPowerActive` -> `SetComponentPowerActive` `SetPowerReactive` -> `SetComponentPowerReactive` `Start` -> `StartComponent` `HotStandby` -> `HotStandbyComponent` `ColdStandby` -> `ColdStandbyComponent` `Stop` -> `StopComponent` `ErrorAck` -> `AckComponentError` Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
0d29dc3 to
8012162
Compare
TalweSingh
approved these changes
Aug 11, 2023
Contributor
Author
|
I will wait for 10 more minutes for people to look into the changes here. If there are no further comments, will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these RPCs did not specify that these act on Components, which was a critical feature of these RPCs. This change adds
Componentto these RPCs, making them easier to read.Here are the details of the RPCs that got renamed:
AddExclusionBounds->AddComponentExclusionBoundsAddInclusionBounds->AddComponentInclusionBoundsSetPowerActive->SetComponentPowerActiveSetPowerReactive->SetComponentPowerReactiveStart->StartComponentHotStandby->HotStandbyComponentColdStandby->ColdStandbyComponentStop->StopComponentErrorAck->AckComponentError