Skip to content

Add Component to methods that act on components #101

@tiyash-basu-frequenz

Description

@tiyash-basu-frequenz

What's needed?

The gRPC methods specified in the provided documentation exhibit clarity in terms of which entity the method verb pertains to. For instance, methods like GetMicrogridMetadata, ListComponents, ListConnections, and StreamComponentData explicitly convey the application of their respective verbs to specific entities. For example, ListComponents promptly indicates that the verb 'List' operates on 'Components', ensuring precise comprehension.

However, this clarity is not consistently present across all methods. Some methods such as Start, HotStandby, ColdStandby, Stop, and ErrorAck lack this specification. As these actions pertain to individual components, it's advisable to incorporate the term Component into their names to ensure clarity.

Furthermore, while methods like SetPowerActive, SetPowerReactive, AddExclusionBounds, and AddInclusionBounds accurately denote the action they perform, they fall short in specifying the entity upon which the action is executed. It's recommended to include the term Component in the names of these methods to enhance precision in conveying the entity of the action.

By adhering to this naming convention, the gRPC methods will consistently provide clear insight into the entities and actions they concern, contributing to a more comprehensible and user-friendly API documentation.

Proposed solution

The following method names require revision:

  • AddExclusionBounds should be renamed to AddComponentExclusionBounds.
  • AddInclusionBounds should be renamed to AddComponentInclusionBounds.
  • SetPowerActive should be renamed to SetComponentPowerActive.
  • SetPowerReactive should be renamed to SetComponentPowerReactive.
  • Start should be renamed to StartComponent.
  • HotStandby should be renamed to HotStandbyComponent.
  • ColdStandby should be renamed to ColdStandbyComponent.
  • Stop should be renamed to StopComponent.

By incorporating the term "Component" into these method names, the actions will be distinctly associated with the relevant entity, leading to greater clarity and coherence within the API documentation.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

Metadata

Metadata

Labels

part:protobufAffects the protocol buffer definition filespriority:❓We need to figure out how soon this should be addressedtype:enhancementNew feature or enhancement visitble to users

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions