-
Notifications
You must be signed in to change notification settings - Fork 8
Report unused imports in CI #228
Copy link
Copy link
Closed
Labels
part:❓We need to figure out which part is affectedWe need to figure out which part is affectedpriority:❓We need to figure out how soon this should be addressedWe need to figure out how soon this should be addressedtype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Milestone
Description
Metadata
Metadata
Assignees
Labels
part:❓We need to figure out which part is affectedWe need to figure out which part is affectedpriority:❓We need to figure out how soon this should be addressedWe need to figure out how soon this should be addressedtype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
What's needed?
We have seen at least once that our protobuf files had unused imports. This did not cause any issue with Rust or Python toolcahins, but caused issues with a Go toolchain (used for building the gRPC gateway). This needed to be fixed.
We need the CI to catch such unused imports, so that
a. our toolchains do not break
b. our proto definitions stay clean
The CI should also fail on finding unused imports.
Proposed solution
The first solution that comes to mind is to run protoc to generate Go code, since that definitely broke. Howeverm there could be other solutions, including the linter. We need to check.
Use cases
No response
Alternatives and workarounds
No response
Additional context
No response