Cleanup#225
Merged
tiyash-basu-frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom Mar 25, 2024
Merged
Conversation
912ebc7 to
43a3d52
Compare
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
43a3d52 to
77c9df4
Compare
hannah-stevenson-frequenz
approved these changes
Mar 25, 2024
Marenz
reviewed
Mar 25, 2024
Marenz
approved these changes
Mar 25, 2024
Contributor
Marenz
left a comment
There was a problem hiding this comment.
I mean, approve, sure, but maybe you want to not add the release notes message in the first place instead of removing it in the next commit ;)
Contributor
|
Ah, too late I guess |
Contributor
Author
You are probably mistaken here (or perhaps I am :) ). Let's discuss in the thread #225 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.