Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
| process, | ||
| }; | ||
|
|
||
| fn main() -> io::Result<()> { |
There was a problem hiding this comment.
We can code golf on this since it is mostly generated but since it is only a tool that is going to run once in a while I was not too worried about that and was only concerned with correctness.
There was a problem hiding this comment.
Not worth the effort IMO unless it is slowing things down
|
|
||
| it('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { | ||
| // This test hangs under some unknown circumstances in parallel mode | ||
| it.skip('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { |
There was a problem hiding this comment.
Forgot to remove the skip?
There was a problem hiding this comment.
It sort of passes in my open PR so not sure we should skip it
There was a problem hiding this comment.
This test hangs under some unknown circumstances in parallel mode. Had to skip it so the e2e tests pass. Open to ideas about how to fix that but it's outside the scope of this PR
There was a problem hiding this comment.
It is probably some race condition that happens in some cases but still it's a flaky test. We have some options
- A: We prefer to keep it as is but it wastes a lot of time in the CI and during when it hangs and we don't know exactly if the hang is because of this test or some new test we've written or changed.
- B: We Prefer to fix it (not in the scope of this PR)
- C: We prefer to skip it to make sure it's not going to cause issues in future.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
In my big Schemas PR, I was going through a lot of the e2e tests that need to be updated due to the schema grant changes, and I found quite a few missing awaits; could be that's causing things to hang randomly.
There was a problem hiding this comment.
Is there a lint we can turn on for missing await in an async function?
There was a problem hiding this comment.
@joe I can look to see if that is a possibility.
Based on the feedback I'm going to enable this and hope for the best and create a ticket for fixing this.
|
|
||
| # Frequency related dependencies | ||
| common-primitives = { default-features = false, path = "../../common/primitives" } | ||
| common-runtime = { path = "../../runtime/common", default-features = false } |
There was a problem hiding this comment.
This is no longer a dev dependency?
There was a problem hiding this comment.
no because we are using the Child tree DB weights in stable weights
|
|
||
| it('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { | ||
| // This test hangs under some unknown circumstances in parallel mode | ||
| it.skip('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Goal
The goal of this PR is to update the database benchmarks
Closes #2601
Discussion
Checklist